kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, Mohammed Gamal <mgamal@redhat.com>
Subject: Re: [PATCH kvm-unit-tests] access: disable phys-bits=36 for now
Date: Fri, 29 May 2020 10:48:39 +0200	[thread overview]
Message-ID: <4832b457-3b6b-b489-4364-a7f5593189a8@redhat.com> (raw)
In-Reply-To: <20200528214527.GG30353@linux.intel.com>

On 28/05/20 23:45, Sean Christopherson wrote:
> On Thu, May 28, 2020 at 06:29:44PM +0200, Vitaly Kuznetsov wrote:
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>
>>> Support for guest-MAXPHYADDR < host-MAXPHYADDR is not upstream yet,
>>> it should not be enabled.  Otherwise, all the pde.36 and pte.36
>>> fail and the test takes so long that it times out.
>>>
>>> Reported-by: Vitaly Kuznetsov <vkuznets@redhat.com>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>  x86/unittests.cfg | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
>>> index bf0d02e..d658bc8 100644
>>> --- a/x86/unittests.cfg
>>> +++ b/x86/unittests.cfg
>>> @@ -116,7 +116,7 @@ extra_params = -cpu qemu64,+x2apic,+tsc-deadline -append tscdeadline_immed
>>>  [access]
>>>  file = access.flat
>>>  arch = x86_64
>>> -extra_params = -cpu host,phys-bits=36
>>> +extra_params = -cpu host
>>>  
>>>  [smap]
>>>  file = smap.flat
>>
>> Works both VMX and SVM, thanks!
> 
> What's the status of the "guest-MAXPHYADDR < host-MAXPHYADDR" work?

Mohammed was working on it, we should have it in 5.9.

> I ask because the AC_PTE_BIT51 and AC_PDE_BIT51 subtests are broken
> on CPUs with 52 bit PAs.  Is it worth sending a patch to temporarily
> disable those tests if MAXPHYADDR=52?
It's a QEMU bug that it does not enable host_phys_bits=on by default for
"-cpu host".  For now I'll tweak this patch to add it manually.

Paolo


  reply	other threads:[~2020-05-29  8:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-28 12:47 [PATCH kvm-unit-tests] access: disable phys-bits=36 for now Paolo Bonzini
2020-05-28 16:29 ` Vitaly Kuznetsov
2020-05-28 21:45   ` Sean Christopherson
2020-05-29  8:48     ` Paolo Bonzini [this message]
2020-05-29 12:22       ` Mohammed Gamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4832b457-3b6b-b489-4364-a7f5593189a8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mgamal@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).