From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED1EFC433F5 for ; Fri, 22 Oct 2021 07:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE3BF610D2 for ; Fri, 22 Oct 2021 07:14:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232064AbhJVHQi (ORCPT ); Fri, 22 Oct 2021 03:16:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33991 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230428AbhJVHQh (ORCPT ); Fri, 22 Oct 2021 03:16:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634886860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cza0h9oBTg6po/zAY8pKYRgVqaiZyyoRw+riljno5Nw=; b=RV0q8prrvrH0zKutXlhyBGnSWutPfZmQy2h9rPraE1Mx/q/AKHEcqF80ev85pmE7qXyUCD RnDIn5camHRqgVTI+RQA1zOI3S/RnYQ8KuvrVC4jgAC1S69Udqb2m6x7leKYcPMnNsW4vl UWazlQp1jv+P8xhytninYz96XSRWtRc= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-545-YtxDdht8PAWFKFbvsp9hJw-1; Fri, 22 Oct 2021 03:14:18 -0400 X-MC-Unique: YtxDdht8PAWFKFbvsp9hJw-1 Received: by mail-ed1-f70.google.com with SMTP id d3-20020a056402516300b003db863a248eso2770949ede.16 for ; Fri, 22 Oct 2021 00:14:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Cza0h9oBTg6po/zAY8pKYRgVqaiZyyoRw+riljno5Nw=; b=MxGp9/tLSsvxtbrNGMqf9+2XXg53AJ4d4HTClB3kR/JK3oS/T7qDHLV/4dVNot/05y y8fMiQ9ArdpC/2i6SY4qoGoEjKf80J75/eUaePxUTmKUrZhmmUjoLMNWLgWIizU5/JJY SallXyFx4BCQ6w3ZIS0DvxdzkxsUmMtJk+R0KrnJEqN5j83MkM90RAYOKy958idNx7id dTzOq4WONVC91Y+L5751V/DD3unG/btPa85dCgarrOzSqt67HeMd2Fkc2b/f0TCWhoVd 6L8Pgyy1DJY+PaahOJoINfwd4iQuUEOH0WZYWLJ5n0tnKltEvg/3ATnXr06bHMfFrGWL c5Fg== X-Gm-Message-State: AOAM533m8OOElWogE7LmdI+RbZYnCSnRZpqVb/t3oKctlIZW5iz4Rbed Uud9Kg1+sYHxPHfh7xfmaPx8d8eJsTkvX2ErmdUV/SYbvjNiHljuPHwfTrqsWappn3HLvFVjwbv BeAc0rtB+eW9P X-Received: by 2002:a05:6402:4309:: with SMTP id m9mr15085429edc.272.1634886857517; Fri, 22 Oct 2021 00:14:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziS1VmXe4Oyn5sD/JRqqBCmT5lfUoAQyDpJpl8mvevLLoT/oQS/Xmpls8mjaFdQkbQ87FWWg== X-Received: by 2002:a05:6402:4309:: with SMTP id m9mr15085402edc.272.1634886857348; Fri, 22 Oct 2021 00:14:17 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id i6sm3374758ejd.57.2021.10.22.00.14.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 00:14:16 -0700 (PDT) Message-ID: <48953634-5b7c-72d6-5fcb-a1b25800f443@redhat.com> Date: Fri, 22 Oct 2021 09:14:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3 4/8] nSVM: use vmcb_save_area_cached in nested_vmcb_valid_sregs() Content-Language: en-US To: Emanuele Giuseppe Esposito , kvm@vger.kernel.org Cc: Maxim Levitsky , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org References: <20211011143702.1786568-1-eesposit@redhat.com> <20211011143702.1786568-5-eesposit@redhat.com> From: Paolo Bonzini In-Reply-To: <20211011143702.1786568-5-eesposit@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 11/10/21 16:36, Emanuele Giuseppe Esposito wrote: > + > +out_free_save: > + memset(&svm->nested.save, 0, sizeof(struct vmcb_save_area_cached)); > + This memset is not strictly necessary, is it? (Same for out_free_ctl later on). Paolo