From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Subject: Re: [PATCH -tip 0/6 V4] tracing: kprobe-based event tracer Date: Fri, 03 Apr 2009 12:55:12 -0400 Message-ID: <49D63F70.7040308@redhat.com> References: <49D4F4B5.9040107@redhat.com> <20090403112639.GC31399@elte.hu> <49D5F80B.7000305@redhat.com> <49D61B56.9020408@redhat.com> <20090403142325.GA14932@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Avi Kivity , "H. Peter Anvin" , Frederic Weisbecker , Steven Rostedt , Ananth N Mavinakayanahalli , Andrew Morton , Andi Kleen , kvm@vger.kernel.org, systemtap-ml , LKML , Vegard Nossum To: Ingo Molnar , Jim Keniston Return-path: In-Reply-To: <20090403142325.GA14932@elte.hu> List-Unsubscribe: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > * Masami Hiramatsu wrote: > >> Hmm, I'd like to know actually kvm aims to emulate all kinds of >> instructions. If so, I might find some bugs in x86_emulate.c. >> However, I don't know all bugs. To find all of them, we have to >> port x86_emulate.c to user-space, decode binaries with it, and >> compare its output with another decoder, as Jim had done with >> insn.c. >> >> https://www.redhat.com/archives/utrace-devel/2009-March/msg00031.html > > btw., i'd suggest we put a build time check for this into the kernel > version as well. For example to decode the vmlinux via objdump, run > it through your decoder as well and compare the results. Put under a > CONFIG_DEBUG_X86_DECODER_TEST kind of (deault-off) build-time > self-test. > > This would ensure that the kernel we are running is fully supported > by the decoder - even as GCC/GAS starts using new instructions, etc. > > How does this sound to you? Thanks! That is a good idea. Jim, would you think you can port your script into kernel tree? Thank you, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com