From: Anthony Liguori <aliguori@us.ibm.com>
To: Alex Williamson <alex.williamson@hp.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH 2/2] qemu:bios: Read external SMBIOS entries from the VM
Date: Mon, 06 Apr 2009 14:52:40 -0500 [thread overview]
Message-ID: <49DA5D88.3010201@us.ibm.com> (raw)
In-Reply-To: <1237835467.15558.5.camel@lappy>
Alex Williamson wrote:
> SMBIOS entries can be read from the VM using the same mechanism
> as additional ACPI tables. External entries will supercede
> generated entries.
>
> Signed-off-by: Alex Williamson <alex.williamson@hp.com>
> +
> + /* A type 1 entry provides a UUID, but so does the QEMU_CFG_UUID
> + * port. If the QEMU_CFG_UUID value is not zero, use it, otherwise
> + * use whatever was in the provided table. */
> + if (type == 1) {
> + const static uint8_t null_uuid[16] = { 0 };
> + if (memcmp(bios_uuid, null_uuid, 16)) {
> + struct smbios_type_1 *t = (struct smbios_type_1 *)*q;
> + memcpy(t->uuid, bios_uuid, 16);
> + }
> + }
>
This is what I was getting at in my other post. I'd sort of rather that
a certain set of SMBIOS tables be specified at a higher level (like
uuid, manufacture, vendor, etc.) and the blobs just be the OEM tables.
I think that matches the work going on with the device configuration
files more appropriately.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-04-06 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 19:05 [PATCH 0/2] qemu: SMBIOS passing support Alex Williamson
2009-03-23 19:11 ` [PATCH 1/2] qemu: Allow SMBIOS entries to be loaded and provided to the VM BIOS Alex Williamson
2009-04-06 19:50 ` Anthony Liguori
2009-04-06 22:34 ` Alex Williamson
2009-04-06 22:42 ` Anthony Liguori
2009-04-07 19:34 ` Alex Williamson
2009-04-07 19:49 ` Anthony Liguori
2009-03-23 19:11 ` [PATCH 2/2] qemu:bios: Read external SMBIOS entries from the VM Alex Williamson
2009-04-06 19:52 ` Anthony Liguori [this message]
2009-03-30 13:59 ` [PATCH 0/2] qemu: SMBIOS passing support Alex Williamson
2009-03-30 14:05 ` Gleb Natapov
2009-03-30 14:38 ` Daniel P. Berrange
2009-03-30 14:59 ` Avi Kivity
2009-03-30 15:40 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DA5D88.3010201@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).