From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/9] Add lcall decoding. Date: Sat, 11 Apr 2009 14:09:58 +0300 Message-ID: <49E07A86.602@redhat.com> References: <20090405135902.3014.62767.stgit@trex.usersys.redhat.com> <20090405135907.3014.69172.stgit@trex.usersys.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60295 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbZDKLKC (ORCPT ); Sat, 11 Apr 2009 07:10:02 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n3BBA2GB010885 for ; Sat, 11 Apr 2009 07:10:02 -0400 In-Reply-To: <20090405135907.3014.69172.stgit@trex.usersys.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > No emulation yet. > > Signed-off-by: Gleb Natapov > --- > > arch/x86/kvm/x86_emulate.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c > index c015063..fe0dec2 100644 > --- a/arch/x86/kvm/x86_emulate.c > +++ b/arch/x86/kvm/x86_emulate.c > @@ -154,7 +154,8 @@ static u32 opcode_table[256] = { > /* 0x90 - 0x97 */ > DstReg, DstReg, DstReg, DstReg, DstReg, DstReg, DstReg, DstReg, > /* 0x98 - 0x9F */ > - 0, 0, 0, 0, ImplicitOps | Stack, ImplicitOps | Stack, 0, 0, > + 0, 0, SrcImm | Src2Imm16 | ImplicitOps, 0, ImplicitOps | Stack, > + ImplicitOps | Stack, 0, 0, > /* 0xA0 - 0xA7 */ > ByteOp | DstReg | SrcMem | Mov | MemAbs, DstReg | SrcMem | Mov | MemAbs, > ByteOp | DstMem | SrcReg | Mov | MemAbs, DstMem | SrcReg | Mov | MemAbs, > > Please keep 4 or 8 opcodes per line. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.