kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Avi Kivity <avi@redhat.com>
Cc: Beth Kon <eak@us.ibm.com>, Glauber Costa <glommer@redhat.com>,
	kvm <kvm@vger.kernel.org>
Subject: Re: qemu-kvm broken after ./configure --disable-kvm
Date: Sun, 14 Jun 2009 13:25:53 +0200	[thread overview]
Message-ID: <4A34DE41.7070506@web.de> (raw)
In-Reply-To: <4A34DB51.3050700@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Avi Kivity wrote:
> Jan Kiszka wrote:
>> Beth Kon wrote:
>>  
>>> Building latest git with ./configure --disable-kvm breaks with errors in
>>> pcspk.c
>>>     
>>
>> With latest git, things break much earlier in case your host does not
>> provide linux/kvm.h because libkvm-all.h includes it unconditionally.
>>
>>   
> 
> But qemu-kvm carries linux/kvm.h, so this never happens?

1. qemu-kvm does not use its own headers when you specify --disble-kvm.
   That's the technical reason for this bug.

2. Upstream does not, and it's unclear if it ever will (if we push
   recent headers into kvm-kmod, I think there is no urgent need
   anymore). At least for code to-be-pushed upstream, we must not
   rely in this anyway.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2009-06-14 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 12:42 qemu-kvm broken after ./configure --disable-kvm Beth Kon
2009-06-11 13:53 ` Jan Kiszka
2009-06-14 11:13   ` Avi Kivity
2009-06-14 11:25     ` Jan Kiszka [this message]
2009-06-14 11:31       ` Avi Kivity
2009-06-14 12:47         ` Jan Kiszka
2009-06-14 12:58           ` Avi Kivity
2009-06-14 13:06             ` Jan Kiszka
2009-06-14 13:14               ` Avi Kivity
2009-06-23  0:41 ` Dustin Kirkland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A34DE41.7070506@web.de \
    --to=jan.kiszka@web.de \
    --cc=avi@redhat.com \
    --cc=eak@us.ibm.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).