Re: [PATCH 1/8] Provide KVMState definition outside CONFIG_KVM

From: Avi Kivity <avi@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 1/8] Provide KVMState definition outside CONFIG_KVM
Date: Wed, 08 Jul 2009 16:22:22 +0300	[thread overview]
Message-ID: <4A549D8E.6070109@redhat.com> (raw)
In-Reply-To: <1247058542-31211-2-git-send-email-glommer@redhat.com>

On 07/08/2009 04:08 PM, Glauber Costa wrote:
> This will allow qemu-kvm to refer to the structure, since qemu-kvm relies
> on USE_KVM, not CONFIG_KVM. This should be sent to qemu.git as well
>
> Signed-off-by: Glauber Costa<glommer@redhat.com>
> ---
>   kvm.h |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kvm.h b/kvm.h
> index d9723d7..7648c49 100644
> --- a/kvm.h
> +++ b/kvm.h
> @@ -18,6 +18,9 @@
>   #include "sys-queue.h"
>   #include "libkvm-all.h"
>
> +struct KVMState;
> +typedef struct KVMState KVMState;
> +
>   #ifdef KVM_UPSTREAM
>
>   #ifdef CONFIG_KVM
> @@ -65,9 +68,6 @@ int kvm_update_guest_debug(CPUState *env, unsigned long reinject_trap);
>
>   /* internal API */
>
> -struct KVMState;
> -typedef struct KVMState KVMState;
> -
>   int kvm_ioctl(KVMState *s, int type, ...);
>
>   int kvm_vm_ioctl(KVMState *s, int type, ...);
>    

Not really needed - we can duplicate these two lines where we use them.  
Since they'll later go away, we avoid some (minimal) churn.

-- 
error compiling committee.c: too many arguments to function