From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/8] use kvm_upstream sw_breakpoints structure Date: Wed, 08 Jul 2009 22:55:13 +0300 Message-ID: <4A54F9A1.6000804@redhat.com> References: <1247058542-31211-1-git-send-email-glommer@redhat.com> <1247058542-31211-2-git-send-email-glommer@redhat.com> <1247058542-31211-3-git-send-email-glommer@redhat.com> <1247058542-31211-4-git-send-email-glommer@redhat.com> <1247058542-31211-5-git-send-email-glommer@redhat.com> <1247058542-31211-6-git-send-email-glommer@redhat.com> <1247058542-31211-7-git-send-email-glommer@redhat.com> <1247058542-31211-8-git-send-email-glommer@redhat.com> <4A549EBF.5040900@redhat.com> <20090708133941.GY3528@poweredge.glommer> <4A54A2A7.7040309@redhat.com> <4A54B9E7.9000801@web.de> <4A54F71A.8000407@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37736 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214AbZGHTy7 (ORCPT ); Wed, 8 Jul 2009 15:54:59 -0400 In-Reply-To: <4A54F71A.8000407@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 07/08/2009 10:44 PM, Jan Kiszka wrote: > > Deferred until v2. My first impression is that too much upstream code is > moved or touched. > > Glauber, if you want to use some function that is currently under > KVM_UPSTREAM, don't move it, just drop the #ifdef around it. And when > done, have a look at the diff between upstream and qemu-kvm to avoid > unneeded variations. > Yes. I though that's what we'd agreed, but forgot to verify it. The only difference should be #endif/#ifdef pairs. > Another question: What prevents using CONFIG_KVM also for qemu-kvm? I > would rather mask out yet unused upstream code via the well-known > KVM_UPSTREAM and drop the easily confusable USE_KVM defines. > Good idea, would simplify ./configure as well. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.