From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [KVM PATCH v10 2/2] KVM: add ioeventfd support
Date: Sun, 12 Jul 2009 11:48:06 +0300
Message-ID: <4A59A346.5040305@redhat.com>
References: <20090707210023.21953.22087.stgit@dev.haskins.net> <20090707210849.21953.93817.stgit@dev.haskins.net> <4A56060C.4090206@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Gregory Haskins <ghaskins@novell.com>, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, mst@redhat.com
To: Gregory Haskins <gregory.haskins@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:35767 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751058AbZGLIpP (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 12 Jul 2009 04:45:15 -0400
In-Reply-To: <4A56060C.4090206@gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 07/09/2009 06:00 PM, Gregory Haskins wrote:
>
>> +		bool wildcard = args->flags&  KVM_IOEVENTFD_FLAG_DATAMATCH ?
>> +			true : false;
>>
>>      
> Doh!  Inverted logic.  "wildcard" should be "false" if DATAMATCH is
> defined in the flags.
>
> Avi, please reverse true/false here before accepting (assuming a v11
> respin isn't needed).  Of course, if you would prefer me to just submit
> a new patch, that is fine too.
>
>    

I changed it to !(...).  I find the predicate ? true : false idiom 
confusing.

-- 
error compiling committee.c: too many arguments to function