From: Jan Kiszka <jan.kiszka@web.de>
To: Aidan Marks <aidan@cisco.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] x86: Pick up local arch trace header
Date: Sun, 20 Sep 2009 10:56:22 +0200 [thread overview]
Message-ID: <4AB5EE36.9060506@web.de> (raw)
In-Reply-To: <4AB550A4.20105@cisco.com>
[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]
Aidan Marks wrote:
> Hi Jan
>
> thanks, applied your patch, getting further, but now missing mmutrace.h...
>
> vger kvm-kmod-devel-88 # make
> make -C /lib/modules/2.6.31-gentoo/build M=`pwd` \
> LINUXINCLUDE="-I`pwd`/include -Iinclude \
> -Iarch/x86/include -I`pwd`/include-compat \
> -include include/linux/autoconf.h \
> -include `pwd`/x86/external-module-compat.h " \
> "$@"
> make[1]: Entering directory `/usr/src/linux-2.6.31-gentoo'
> LD /tmp/kvm-kmod-devel-88/x86/built-in.o
> CC [M] /tmp/kvm-kmod-devel-88/x86/svm.o
> CC [M] /tmp/kvm-kmod-devel-88/x86/vmx.o
> CC [M] /tmp/kvm-kmod-devel-88/x86/vmx-debug.o
> CC [M] /tmp/kvm-kmod-devel-88/x86/kvm_main.o
> CC [M] /tmp/kvm-kmod-devel-88/x86/x86.o
> CC [M] /tmp/kvm-kmod-devel-88/x86/mmu.o
> In file included from /tmp/kvm-kmod-devel-88/x86/mmutrace.h:220,
> from /tmp/kvm-kmod-devel-88/x86/mmu.c:184:
> include/trace/define_trace.h:53:43: error: ./mmutrace.h: No such file or
> directory
> make[3]: *** [/tmp/kvm-kmod-devel-88/x86/mmu.o] Error 1
> make[2]: *** [/tmp/kvm-kmod-devel-88/x86] Error 2
> make[1]: *** [_module_/tmp/kvm-kmod-devel-88] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.6.31-gentoo'
> make: *** [all] Error 2
Here is a better approach:
diff --git a/include/arch/x86/kvm b/include/arch/x86/kvm
new file mode 120000
index 0000000..c635817
--- /dev/null
+++ b/include/arch/x86/kvm
@@ -0,0 +1 @@
+../../../x86
\ No newline at end of file
I also pushed a kvm-kmod update for 2.6.31-based modules in my repos,
see
git://git.kiszka.org/kvm-kmod.git queue
To use this one instead of devel-88, clone it and run
git submodule update --init
./configure
make sync
make
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2009-09-20 8:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-19 2:19 kvm-kmod 88 or git not working with 2.6.31 Aidan Marks
2009-09-19 7:13 ` [PATCH] x86: Pick up local arch trace header (was: kvm-kmod 88 or git not working with 2.6.31) Jan Kiszka
2009-09-19 21:44 ` [PATCH] x86: Pick up local arch trace header Aidan Marks
2009-09-20 8:56 ` Jan Kiszka [this message]
2009-09-20 11:02 ` Aidan Marks
2009-09-20 11:42 ` Jan Kiszka
2009-09-20 12:55 ` Aidan Marks
2009-09-20 13:24 ` Jan Kiszka
2009-09-20 13:49 ` Aidan Marks
2009-09-23 19:28 ` Jorge Lucángeli Obes
2009-09-24 6:42 ` Jan Kiszka
2009-09-24 7:04 ` Jorge Lucángeli Obes
2009-09-24 7:44 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB5EE36.9060506@web.de \
--to=jan.kiszka@web.de \
--cc=aidan@cisco.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).