From: Avi Kivity <avi@redhat.com>
To: Huang Ying <ying.huang@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Anthony Liguori <aliguori@us.ibm.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH -v4] QEMU-KVM: MCE: Relay UCR MCE to guest
Date: Mon, 21 Sep 2009 13:08:38 +0300 [thread overview]
Message-ID: <4AB750A6.1090000@redhat.com> (raw)
In-Reply-To: <1253501005.15717.548.camel@yhuang-dev.sh.intel.com>
On 09/21/2009 05:43 AM, Huang Ying wrote:
> UCR (uncorrected recovery) MCE is supported in recent Intel CPUs,
> where some hardware error such as some memory error can be reported
> without PCC (processor context corrupted). To recover from such MCE,
> the corresponding memory will be unmapped, and all processes accessing
> the memory will be killed via SIGBUS.
>
> For KVM, if QEMU/KVM is killed, all guest processes will be killed
> too. So we relay SIGBUS from host OS to guest system via a UCR MCE
> injection. Then guest OS can isolate corresponding memory and kill
> necessary guest processes only. SIGBUS sent to main thread (not VCPU
> threads) will be broadcast to all VCPU threads as UCR MCE.
>
>
>
> --- a/qemu-kvm.c
> +++ b/qemu-kvm.c
> @@ -27,10 +27,23 @@
> #include<sys/mman.h>
> #include<sys/ioctl.h>
> #include<signal.h>
> +#include<sys/signalfd.h>
>
This causes a build failure, since not all hosts have <sys/signalfd.h>,
but more importantly:
> +
> +static void sigbus_handler(int n, struct signalfd_siginfo *siginfo, void *ctx)
> +{
>
Here you accept signalfd_siginfo, while
> +
> + memset(&action, 0, sizeof(action));
> + action.sa_flags = SA_SIGINFO;
> + action.sa_sigaction = (void (*)(int, siginfo_t*, void*))sigbus_handler;
> + sigaction(SIGBUS,&action, NULL);
> + prctl(PR_MCE_KILL, 1, 1);
> return 0;
>
here you arm the function with something that will send it a siginfo_t.
So it looks like this is broken if a signal is ever received directly?
But can this happen due to signalfd?
> }
>
> @@ -1962,7 +2116,10 @@ static void sigfd_handler(void *opaque)
> }
>
> sigaction(info.ssi_signo, NULL,&action);
> - if (action.sa_handler)
> + if ((action.sa_flags& SA_SIGINFO)&& action.sa_sigaction)
> + action.sa_sigaction(info.ssi_signo,
> + (siginfo_t *)&info, NULL);
> + else if (action.sa_handler)
> action.sa_handler(info.ssi_signo);
>
The whole "extract handler from sigaction and call it" was a hack.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-21 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 2:43 [PATCH -v4] QEMU-KVM: MCE: Relay UCR MCE to guest Huang Ying
2009-09-21 9:21 ` Avi Kivity
2009-09-21 10:08 ` Avi Kivity [this message]
2009-09-22 1:12 ` Huang Ying
2009-09-22 6:14 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB750A6.1090000@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=andi@firstfloor.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).