From: Rik van Riel <riel@redhat.com>
To: Zachary Amsden <zamsden@redhat.com>
Cc: Glauber Costa <glommer@redhat.com>,
kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com
Subject: Re: [RFC 2/7] change headers preparing for steal time
Date: Thu, 26 Aug 2010 17:04:02 -0400 [thread overview]
Message-ID: <4C76D6C2.3010608@redhat.com> (raw)
In-Reply-To: <4C76D22D.9010007@redhat.com>
On 08/26/2010 04:44 PM, Zachary Amsden wrote:
> On 08/25/2010 11:43 AM, Glauber Costa wrote:
>> This guest/host common patch prepares infrastructure for
>> the steal time implementation. Some constants are added,
>> and a name change happens in pvclock vcpu structure.
>>
>> Signed-off-by: Glauber Costa<glommer@redhat.com>
>> ---
>> arch/x86/include/asm/kvm_para.h | 1 +
>> arch/x86/include/asm/pvclock-abi.h | 4 +++-
>> 2 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/include/asm/kvm_para.h
>> b/arch/x86/include/asm/kvm_para.h
>> index 05eba5e..1759c81 100644
>> --- a/arch/x86/include/asm/kvm_para.h
>> +++ b/arch/x86/include/asm/kvm_para.h
>> @@ -25,6 +25,7 @@
>> * in pvclock structure. If no bits are set, all flags are ignored.
>> */
>> #define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 24
>> +#define KVM_FEATURE_CLOCKSOURCE_STEAL_BIT 25
>>
>> #define MSR_KVM_WALL_CLOCK 0x11
>> #define MSR_KVM_SYSTEM_TIME 0x12
>> diff --git a/arch/x86/include/asm/pvclock-abi.h
>> b/arch/x86/include/asm/pvclock-abi.h
>> index 35f2d19..417061b 100644
>> --- a/arch/x86/include/asm/pvclock-abi.h
>> +++ b/arch/x86/include/asm/pvclock-abi.h
>> @@ -24,7 +24,7 @@
>>
>> struct pvclock_vcpu_time_info {
>> u32 version;
>> - u32 pad0;
>> + u32 steal_time;
>> u64 tsc_timestamp;
>> u64 system_time;
>> u32 tsc_to_system_mul;
>> @@ -40,5 +40,7 @@ struct pvclock_wall_clock {
>> } __attribute__((__packed__));
>>
>> #define PVCLOCK_TSC_STABLE_BIT (1<< 0)
>> +#define PVCLOCK_STEAL_BIT (2<< 0)
>> +
>> #endif /* __ASSEMBLY__ */
>> #endif /* _ASM_X86_PVCLOCK_ABI_H */
>
>
> Will 32 bits be enough?
Good question. Reading the rest of the code,
I suspect it won't be, but Glauber will know
better.
--
All rights reversed
next prev parent reply other threads:[~2010-08-26 21:04 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 21:43 [RFC 0/7] KVM steal time implementation Glauber Costa
2010-08-25 21:43 ` [RFC 1/7] Implement getnsboottime kernel API Glauber Costa
2010-08-25 21:43 ` [RFC 2/7] change headers preparing for steal time Glauber Costa
2010-08-25 21:43 ` [RFC 3/7] measure time out of guest Glauber Costa
2010-08-25 21:43 ` [RFC 4/7] change kernel accounting to include steal time Glauber Costa
2010-08-25 21:43 ` [RFC 5/7] kvm steal time implementation Glauber Costa
2010-08-25 21:43 ` [RFC 6/7] touch softlockup watchdog Glauber Costa
2010-08-25 21:43 ` [RFC 7/7] tell guest about steal time feature Glauber Costa
2010-08-26 22:13 ` [RFC 5/7] kvm steal time implementation Rik van Riel
2010-08-26 22:35 ` Glauber Costa
2010-08-26 17:23 ` [RFC 4/7] change kernel accounting to include steal time Marcelo Tosatti
2010-08-26 20:28 ` Glauber Costa
2010-08-26 20:47 ` Marcelo Tosatti
2010-08-26 21:05 ` Rik van Riel
2010-08-26 21:13 ` Glauber Costa
2010-08-26 21:14 ` Anthony Liguori
2010-08-26 21:40 ` Glauber Costa
2010-08-26 23:12 ` Marcelo Tosatti
2010-08-27 0:33 ` Glauber Costa
2010-08-27 15:25 ` Marcelo Tosatti
2010-08-26 21:19 ` Rik van Riel
2010-08-26 21:39 ` Glauber Costa
2010-08-29 9:59 ` Avi Kivity
2010-08-29 15:13 ` Rik van Riel
2010-08-29 15:25 ` Avi Kivity
2010-08-29 15:42 ` Rik van Riel
2010-08-29 15:47 ` Avi Kivity
2010-08-30 12:42 ` Glauber Costa
2010-08-30 13:15 ` Avi Kivity
2010-08-26 20:54 ` [RFC 3/7] measure time out of guest Zachary Amsden
2010-08-26 21:14 ` Glauber Costa
2010-08-29 9:53 ` Avi Kivity
2010-08-26 20:44 ` [RFC 2/7] change headers preparing for steal time Zachary Amsden
2010-08-26 21:04 ` Rik van Riel [this message]
2010-08-26 21:17 ` Glauber Costa
2010-08-26 22:11 ` Rik van Riel
2010-08-29 9:51 ` Avi Kivity
2010-08-30 12:44 ` Glauber Costa
2010-08-30 13:10 ` Avi Kivity
2010-08-26 19:46 ` [RFC 1/7] Implement getnsboottime kernel API Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C76D6C2.3010608@redhat.com \
--to=riel@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).