kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm_stat: ignore events that have never occured
Date: Mon, 06 Sep 2010 10:39:45 +0200	[thread overview]
Message-ID: <4C84A8D1.4090805@redhat.com> (raw)
In-Reply-To: <1283325449-18321-1-git-send-email-avi@redhat.com>

On 09/01/10 09:17, Avi Kivity wrote:
> Less cluttered display.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  kvm/kvm_stat |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kvm/kvm_stat b/kvm/kvm_stat
> index 4a16277..d373c60 100755
> --- a/kvm/kvm_stat
> +++ b/kvm/kvm_stat
> @@ -315,6 +315,8 @@ def tui(screen, stats):
>              if row >= screen.getmaxyx()[0]:
>                  break
>              values = s[key]
> +            if not values[0] and not values[1]:
> +                break
>              col = 1
>              screen.addstr(row, col, key)
>              col += label_width

Is this just for the live display update, or does it also affect single
run outputs?

If the latter, it will break scripting where you do a first run, then a
second run and then calculate the result based on the changes.

Cheers,
Jes


  reply	other threads:[~2010-09-06  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-01  7:17 [PATCH] kvm_stat: ignore events that have never occured Avi Kivity
2010-09-06  8:39 ` Jes Sorensen [this message]
2010-09-06  8:55   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C84A8D1.4090805@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).