From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: ia64: define kvm_lapic_enabled() to fix a compile error Date: Mon, 27 Sep 2010 11:49:59 +0200 Message-ID: <4CA068C7.3020004@redhat.com> References: <20100902175500.ac552016.yoshikawa.takuya@oss.ntt.co.jp> <4C7F6707.7030004@redhat.com> <4CA03EED.9080404@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org, kvm-ia64@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12433 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752833Ab0I0JuF (ORCPT ); Mon, 27 Sep 2010 05:50:05 -0400 In-Reply-To: <4CA03EED.9080404@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 09/27/2010 08:51 AM, Takuya Yoshikawa wrote: > (2010/09/02 17:57), Avi Kivity wrote: >> On 09/02/2010 11:55 AM, Takuya Yoshikawa wrote: >>> The following patch >>> >>> commit 57ce1659316f4ca298919649f9b1b55862ac3826 >>> KVM: x86: In DM_LOWEST, only deliver interrupts to vcpus with >>> enabled LAPIC's >>> >>> ignored the fact that kvm_irq_delivery_to_apic() was also used by ia64. >>> >>> We define kvm_lapic_enabled() to fix a compile error caused by this. >>> This will have the same effect as reverting the problematic patch >>> for ia64. >> >> Applied, thanks. >> > > Hi, > > Isn't this a candidate for 2.6.36? > > Though ia64 kvm is in experimental stage and may not be working now, > compile > errors may be bad for other people who just want to compile ia64 linux. > Maybe we should make ia64 kvm depend on CONFIG_BROKEN. It has been "experimental" for quite a while. -- error compiling committee.c: too many arguments to function