From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [regression] KVM: hangs and "irq timeout" booting HURD unless -no-kvm-irqchip passed Date: Tue, 08 Feb 2011 16:43:33 +0200 Message-ID: <4D515695.5080600@redhat.com> References: <1283171743-10766-1-git-send-email-avi@redhat.com> <1283171743-10766-2-git-send-email-avi@redhat.com> <20110207060030.GA1896@elie> <4D4FE7E5.2040308@redhat.com> <20110207124513.GB14984@redhat.com> <20110207132729.GC14984@redhat.com> <20110208014032.GB1858@elie> <20110208120037.GJ14984@redhat.com> <20110208142253.GA8243@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Jonathan Nieder , kvm@vger.kernel.org, Michael Tokarev , Guillem Jover To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46745 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754186Ab1BHOnr (ORCPT ); Tue, 8 Feb 2011 09:43:47 -0500 In-Reply-To: <20110208142253.GA8243@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 02/08/2011 04:22 PM, Marcelo Tosatti wrote: > I don't think the isr_ack logic is overly complex that it should be > removed. For some cases it is still beneficial, see example case on > commit e48258009d941, which is not handled by kick coalescing of > kvm_vcpu_kick. On the other hand, I think it can be done differently. For example LVT0 is probably programmed to mask interrupts; we can simply look at it and not kick if that's the case. We can use notifiers from the lapic to the pic to avoid looking at lapic data. The advantage in this way is that we avoid introducing state, instead relying on existing state. New state is always bad since it has to be kept in sync with guest visible state. -- error compiling committee.c: too many arguments to function