From: Nadav Amit <namit@vmware.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Wei Wang <wei.w.wang@intel.com>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
kvm list <kvm@vger.kernel.org>,
Xavier Deguillard <xdeguillard@vmware.com>,
Andrew Morton <akpm@linux-foundation.org>,
"pagupta@redhat.com" <pagupta@redhat.com>,
Rik van Riel <riel@surriel.com>,
Dave Hansen <dave.hansen@intel.com>,
David Hildenbrand <david@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
"nitesh@redhat.com" <nitesh@redhat.com>,
"lcapitulino@redhat.com" <lcapitulino@redhat.com>,
"aarcange@redhat.com" <aarcange@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"alexander.h.duyck@linux.intel.com"
<alexander.h.duyck@linux.intel.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2] mm/balloon_compaction: avoid duplicate page removal
Date: Thu, 18 Jul 2019 17:02:07 +0000 [thread overview]
Message-ID: <4FC18511-DD19-4B10-BCAF-906E264B0411@vmware.com> (raw)
In-Reply-To: <20190718082535-mutt-send-email-mst@kernel.org>
> On Jul 18, 2019, at 5:26 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Thu, Jul 18, 2019 at 05:27:20PM +0800, Wei Wang wrote:
>> Fixes: 418a3ab1e778 (mm/balloon_compaction: List interfaces)
>>
>> A #GP is reported in the guest when requesting balloon inflation via
>> virtio-balloon. The reason is that the virtio-balloon driver has
>> removed the page from its internal page list (via balloon_page_pop),
>> but balloon_page_enqueue_one also calls "list_del" to do the removal.
>> This is necessary when it's used from balloon_page_enqueue_list, but
>> not from balloon_page_enqueue_one.
>>
>> So remove the list_del balloon_page_enqueue_one, and update some
>> comments as a reminder.
>>
>> Signed-off-by: Wei Wang <wei.w.wang@intel.com>
>
>
> ok I posted v3 with typo fixes. 1/2 is this patch with comment changes. Pls take a look.
Thanks (Wei, Michael) for taking care of it. Please cc me on future
iterations of the patch.
Acked-by: Nadav Amit <namit@vmware.com>
next prev parent reply other threads:[~2019-07-18 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 9:27 [PATCH v2] mm/balloon_compaction: avoid duplicate page removal Wei Wang
2019-07-18 11:37 ` Michael S. Tsirkin
2019-07-18 12:26 ` Michael S. Tsirkin
2019-07-18 17:02 ` Nadav Amit [this message]
2019-07-18 20:36 ` Andrew Morton
2019-07-18 20:42 ` Michael S. Tsirkin
2019-07-18 20:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC18511-DD19-4B10-BCAF-906E264B0411@vmware.com \
--to=namit@vmware.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=nitesh@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=riel@surriel.com \
--cc=wei.w.wang@intel.com \
--cc=xdeguillard@vmware.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).