From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261D0C43331 for ; Fri, 6 Sep 2019 10:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 016DC2082C for ; Fri, 6 Sep 2019 10:02:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388537AbfIFKCg (ORCPT ); Fri, 6 Sep 2019 06:02:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37248 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfIFKCf (ORCPT ); Fri, 6 Sep 2019 06:02:35 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2AF063082137; Fri, 6 Sep 2019 10:02:35 +0000 (UTC) Received: from [10.36.117.162] (ovpn-117-162.ams2.redhat.com [10.36.117.162]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0C355C1D4; Fri, 6 Sep 2019 10:02:33 +0000 (UTC) Subject: Re: [kvm-unit-tests PATCH] travis.yml: Enable running of tests with TCG To: Thomas Huth , kvm@vger.kernel.org, =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Paolo Bonzini Cc: Drew Jones , Laurent Vivier , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20190830184509.15240-1-thuth@redhat.com> <3cc8a3c5-c86f-5b06-bff0-753ef628c7e3@redhat.com> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <4a9fe8b4-053a-80db-8631-b9f3fd269c82@redhat.com> Date: Fri, 6 Sep 2019 12:02:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3cc8a3c5-c86f-5b06-bff0-753ef628c7e3@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 06 Sep 2019 10:02:35 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 06.09.19 11:54, Thomas Huth wrote: > On 06/09/2019 11.43, David Hildenbrand wrote: >> On 30.08.19 20:45, Thomas Huth wrote: >>> Currently the tests at the end of the .travis.yml script are ignored, >>> since we can not use KVM in the Travis containers. But we can actually >>> run of some of the kvm-unit-tests with TCG instead, to make sure that >>> the binaries are not completely broken. >>> Thus introduce a new TESTS variable that lists the tests which we can >>> run with TCG. Unfortunately, the ppc64 and s390x QEMUs in Ubuntu also >>> need some extra love: The ppc64 version only works with the additional >>> "cap-htm=off" setting. And the s390x package lacks the firmware and >>> refuses to work unless we provide a fake firmware file here. Any file >>> works since the firmware is skipped when "-kernel" is used, so we can >>> simply use one of the pre-existing files in the source tree. >>> >>> Signed-off-by: Thomas Huth >>> --- >>> .travis.yml | 19 ++++++++++++++++++- >>> 1 file changed, 18 insertions(+), 1 deletion(-) >>> >>> diff --git a/.travis.yml b/.travis.yml >>> index a4a165d..6c14953 100644 >>> --- a/.travis.yml >>> +++ b/.travis.yml >>> @@ -20,24 +20,40 @@ env: >>> matrix: >>> - CONFIG="" >>> BUILD_DIR="." >>> + TESTS="vmexit_cpuid vmexit_mov_from_cr8 vmexit_mov_to_cr8 vmexit_ipi >>> + vmexit_ple_round_robin vmexit_tscdeadline vmexit_tscdeadline_immed" >>> - CONFIG="" >>> BUILD_DIR="x86-builddir" >>> + TESTS="ioapic-split ioapic smptest smptest3 eventinj msr port80 syscall >>> + tsc rmap_chain umip intel_iommu vmexit_inl_pmtimer vmexit_ipi_halt" >>> - CONFIG="--arch=arm --cross-prefix=arm-linux-gnueabihf-" >>> BUILD_DIR="." >>> + TESTS="selftest-vectors-kernel selftest-vectors-user selftest-smp" >>> - CONFIG="--arch=arm --cross-prefix=arm-linux-gnueabihf-" >>> BUILD_DIR="arm-buildir" >>> + TESTS="pci-test pmu gicv2-active gicv3-active psci selftest-setup" >>> - CONFIG="--arch=arm64 --cross-prefix=aarch64-linux-gnu-" >>> BUILD_DIR="." >>> + TESTS="selftest-vectors-kernel selftest-vectors-user selftest-smp" >>> - CONFIG="--arch=arm64 --cross-prefix=aarch64-linux-gnu-" >>> BUILD_DIR="arm64-buildir" >>> + TESTS="pci-test pmu gicv2-active gicv3-active psci timer selftest-setup" >>> - CONFIG="--arch=ppc64 --endian=little --cross-prefix=powerpc64le-linux-gnu-" >>> BUILD_DIR="." >>> + TESTS="spapr_hcall emulator rtas-set-time-of-day" >>> + ACCEL="tcg,cap-htm=off" >>> - CONFIG="--arch=ppc64 --endian=little --cross-prefix=powerpc64le-linux-gnu-" >>> BUILD_DIR="ppc64le-buildir" >>> + TESTS="rtas-get-time-of-day rtas-get-time-of-day-base" >>> + ACCEL="tcg,cap-htm=off" >>> - CONFIG="--arch=s390x --cross-prefix=s390x-linux-gnu-" >>> BUILD_DIR="." >>> + TESTS="diag10 diag308" >>> + ACCEL="tcg,firmware=s390x/run" >>> - CONFIG="--arch=s390x --cross-prefix=s390x-linux-gnu-" >>> BUILD_DIR="s390x-builddir" >>> + TESTS="sieve" >>> + ACCEL="tcg,firmware=s390x/run" >> >> What about the other s390x tests? (is the QEMU binary too old to make >> them pass?) > > Yes. All the others are failing. So the QEMU versions is that old that not even the selftest works? :/ Is there a more recent distribution we can use? > >> The issue with TCG is that you can easily get false negatives in case >> the QEMU binary changes (e.g., new Ubuntu release). > > That should not be a big deal, since the Ubuntu version is locked to a > certain release in the travis.yml file. So we should not get a new > version of QEMU by accident here, only if we explicitly update the > "dist:" line in the yml file. Or if the dist updates QEMU. Not sure how often that happens in QEMU. (but as not even the selfest passes, it cannot really get any worse :D ) > >> "to make sure that the binaries are not completely broken" - while I >> understand the intuition behind that, I wonder if this is relevant in >> practice > Well, the test coverage here is certainly far from being perfect, but > it's still better than nothing. Imagine one of the patches changes > common code in the lib/ folder and it only works on one architecture > that the author tested. Chances are quite good that we detect that > problem with this patch now. Better than nothing I guess. -- Thanks, David / dhildenb