kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: Aaron Lewis <aaronlewis@google.com>,
	jmattson@google.com, pshier@google.com, marcorr@google.com,
	kvm@vger.kernel.org
Subject: Re: [PATCH 1/2] kvm: nVMX: Enforce must-be-zero bits in the IA32_VMX_VMCS_ENUM MSR
Date: Tue, 4 Jun 2019 10:52:48 -0700	[thread overview]
Message-ID: <4b50c550-308e-2b88-053e-c6933f9ed320@oracle.com> (raw)
In-Reply-To: <20190531184159.260151-1-aaronlewis@google.com>


On 5/31/19 11:41 AM, Aaron Lewis wrote:
> According to the SDM, bit 0 and bits 63:10 of the IA32_VMX_VMCS_ENUM
> MSR are reserved and are read as 0.
>
> Signed-off-by: Aaron Lewis <aaronlewis@google.com>
> Reviewed-by: Jim Mattson <jmattson@google.com>
> ---
>   arch/x86/kvm/vmx/nested.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 6401eb7ef19c..3438279e76bb 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -1219,6 +1219,8 @@ int vmx_set_vmx_msr(struct kvm_vcpu *vcpu, u32 msr_index, u64 data)
>   	case MSR_IA32_VMX_EPT_VPID_CAP:
>   		return vmx_restore_vmx_ept_vpid_cap(vmx, data);
>   	case MSR_IA32_VMX_VMCS_ENUM:
> +		if (data & (GENMASK_ULL(63, 10) | BIT_ULL(0)))
> +			return -EINVAL;
>   		vmx->nested.msrs.vmcs_enum = data;
>   		return 0;
>   	default:


Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>


  reply	other threads:[~2019-06-04 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 18:41 [PATCH 1/2] kvm: nVMX: Enforce must-be-zero bits in the IA32_VMX_VMCS_ENUM MSR Aaron Lewis
2019-06-04 17:52 ` Krish Sadhukhan [this message]
2019-06-18 14:15   ` Aaron Lewis
2019-07-10 16:08     ` Aaron Lewis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b50c550-308e-2b88-053e-c6933f9ed320@oracle.com \
    --to=krish.sadhukhan@oracle.com \
    --cc=aaronlewis@google.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=marcorr@google.com \
    --cc=pshier@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).