From: David Woodhouse <dwmw2@infradead.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
Coleman Dietsch <dietschc@csp.edu>,
kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
Pavel Skripkin <paskripkin@gmail.com>,
linux-kernel-mentees@lists.linuxfoundation.org,
stable@vger.kernel.org,
syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com
Subject: Re: [PATCH v3 2/2] KVM: x86/xen: Stop Xen timer before changing IRQ
Date: Tue, 09 Aug 2022 14:51:32 +0100 [thread overview]
Message-ID: <4fc1371b83001b4eed1617c37bec6b9d007e45c2.camel@infradead.org> (raw)
In-Reply-To: <43e258cc-71ac-bde4-d1f8-9eb9519928d3@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Tue, 2022-08-09 at 14:59 +0200, Paolo Bonzini wrote:
> On 8/9/22 11:22, David Woodhouse wrote:
> > On Mon, 2022-08-08 at 14:06 -0500, Coleman Dietsch wrote:
> > > Stop Xen timer (if it's running) prior to changing the IRQ vector and
> > > potentially (re)starting the timer. Changing the IRQ vector while the
> > > timer is still running can result in KVM injecting a garbage event, e.g.
> > > vm_xen_inject_timer_irqs() could see a non-zero xen.timer_pending from
> > > a previous timer but inject the new xen.timer_virq.
> >
> > Hm, wasn't that already addressed in the first patch I saw, which just
> > called kvm_xen_stop_timer() unconditionally before (possibly) setting
> > it up again?
>
> Which patch is that?
The one I acked in
https://lore.kernel.org/all/9bad724858b6a06c25ead865b2b3d9dfc216d01c.camel@infradead.org/
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]
next prev parent reply other threads:[~2022-08-09 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 19:06 [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once Coleman Dietsch
2022-08-08 19:06 ` [PATCH v3 2/2] KVM: x86/xen: Stop Xen timer before changing IRQ Coleman Dietsch
2022-08-09 0:34 ` Sean Christopherson
2022-08-09 9:22 ` David Woodhouse
2022-08-09 12:59 ` Paolo Bonzini
2022-08-09 13:51 ` David Woodhouse [this message]
2022-08-09 14:07 ` Sean Christopherson
2022-08-09 14:16 ` David Woodhouse
2022-08-09 14:31 ` Paolo Bonzini
2022-08-09 14:36 ` David Woodhouse
2022-08-09 14:40 ` Sean Christopherson
2022-08-09 14:52 ` David Woodhouse
2022-08-09 0:32 ` [PATCH v3 1/2] KVM: x86/xen: Initialize Xen timer only once Sean Christopherson
2022-08-09 12:59 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fc1371b83001b4eed1617c37bec6b9d007e45c2.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dietschc@csp.edu \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paskripkin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+e54f930ed78eb0f85281@syzkaller.appspotmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).