From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] Revert "KVM: nVMX: always use early vmcs check when EPT is disabled"
Date: Fri, 7 Jun 2019 15:26:48 +0200 [thread overview]
Message-ID: <53423366-f839-9225-2016-dfa36d82da08@redhat.com> (raw)
In-Reply-To: <20190606174939.GF23169@linux.intel.com>
On 06/06/19 19:49, Sean Christopherson wrote:
> On Thu, Jun 06, 2019 at 07:31:13PM +0200, Paolo Bonzini wrote:
>> On 06/06/19 19:08, Sean Christopherson wrote:
>>>> This hunk needs to be moved to patch 1, which then becomes much easier
>>>> to understand...
>>> I kept the revert in a separate patch so that the bug fix could be
>>> easily backported to stable branches (commit 2b27924bb1d4 ("KVM: nVMX:
>>> always use early vmcs check when EPT is disabled" wasn't tagged for
>>> stable).
>>>
>>
>> Yeah, I didn't mark it because of the mess involving the vmx.c split
>> (basically wait and see if someone report it). There was quite some
>> churn so I am a bit wary to do stable backports where I haven't
>> explicitly tested the backport on the oldest affected version.
>
> Do you want me to send a v2 as a single patch? If so, presumably without
> cc'ing stable?
Yes, please do, adding in the comment as well.
Paolo
prev parent reply other threads:[~2019-06-07 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 20:10 [PATCH 0/2] KVM: nVMX: Alternative no-EPT GUEST_CR3 fix Sean Christopherson
2019-05-20 20:10 ` [PATCH 1/2] KVM: nVMX: Stash L1's CR3 in vmcs01.GUEST_CR3 on nested entry w/o EPT Sean Christopherson
2019-06-06 12:24 ` Paolo Bonzini
2019-05-20 20:10 ` [PATCH 2/2] Revert "KVM: nVMX: always use early vmcs check when EPT is disabled" Sean Christopherson
2019-06-06 12:22 ` Paolo Bonzini
2019-06-06 17:08 ` Sean Christopherson
2019-06-06 17:31 ` Paolo Bonzini
2019-06-06 17:49 ` Sean Christopherson
2019-06-07 13:26 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53423366-f839-9225-2016-dfa36d82da08@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).