From: John Snow <jsnow@redhat.com>
To: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>
Cc: "Fam Zheng" <fam@euphon.net>,
"Laurent Vivier" <lvivier@redhat.com>,
"Viktor Prutyanov" <viktor.prutyanov@phystech.edu>,
qemu-block@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Alistair Francis" <alistair@alistair23.me>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Greg Kurz" <groug@kaod.org>, "Max Reitz" <mreitz@redhat.com>,
qemu-ppc@nongnu.org, kvm@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux
Date: Tue, 26 Jan 2021 16:38:57 -0500 [thread overview]
Message-ID: <551e153e-34da-28bd-c67f-d2a688ad987b@redhat.com> (raw)
In-Reply-To: <929c3ec1-9419-908a-6b5e-ce3ae78f6011@redhat.com>
On 1/19/21 8:41 AM, Thomas Huth wrote:
> On 18/01/2021 11.33, Daniel P. Berrangé wrote:
>> On Mon, Jan 18, 2021 at 02:38:07PM +0800, Jiaxun Yang wrote:
>>> Alpine Linux[1] is a security-oriented, lightweight Linux distribution
>>> based on musl libc and busybox.
>>>
>>> It it popular among Docker guests and embedded applications.
>>>
>>> Adding it to test against different libc.
>>>
>>> [1]: https://alpinelinux.org/
>>>
>>> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
>>> ---
>>> tests/docker/dockerfiles/alpine.docker | 57 ++++++++++++++++++++++++++
>>> 1 file changed, 57 insertions(+)
>>> create mode 100644 tests/docker/dockerfiles/alpine.docker
>>>
>>> diff --git a/tests/docker/dockerfiles/alpine.docker
>>> b/tests/docker/dockerfiles/alpine.docker
>>> new file mode 100644
>>> index 0000000000..5be5198d00
>>> --- /dev/null
>>> +++ b/tests/docker/dockerfiles/alpine.docker
>>> @@ -0,0 +1,57 @@
>>> +
>>> +FROM alpine:edge
>>> +
>>> +RUN apk update
>>> +RUN apk upgrade
>>> +
>>> +# Please keep this list sorted alphabetically
>>> +ENV PACKAGES \
>>> + alsa-lib-dev \
>>> + bash \
>>> + bison \
>>
>> This shouldn't be required.
>
> bison and flex were required to avoid some warnings in the past while
> compiling the dtc submodule ... but I thought we got rid of the problem
> at one point in time, so this can be removed now, indeed.
>
>>> + build-base \
>>
>> This seems to be a meta packae that pulls in other
>> misc toolchain packages. Please list the pieces we
>> need explicitly instead.
>
> Looking at the "Depends" list on
> https://pkgs.alpinelinux.org/package/v3.3/main/x86/build-base there are
> only 6 dependencies and we need most of those for QEMU anyway, so I
> think it is ok to keep build-base here.
>
>>> + coreutils \
>>> + curl-dev \
>>> + flex \
>>
>> This shouldn't be needed.
>>
>>> + git \
>>> + glib-dev \
>>> + glib-static \
>>> + gnutls-dev \
>>> + gtk+3.0-dev \
>>> + libaio-dev \
>>> + libcap-dev \
>>
>> Should not be required, as we use cap-ng.
>
> Right.
>
>>> + libcap-ng-dev \
>>> + libjpeg-turbo-dev \
>>> + libnfs-dev \
>>> + libpng-dev \
>>> + libseccomp-dev \
>>> + libssh-dev \
>>> + libusb-dev \
>>> + libxml2-dev \
>>> + linux-headers \
>>
>> Is this really needed ? We don't install kernel-headers on other
>> distros AFAICT.
>
> I tried a build without this package, and it works fine indeed.
>
>>> + lzo-dev \
>>> + mesa-dev \
>>> + mesa-egl \
>>> + mesa-gbm \
>>> + meson \
>>> + ncurses-dev \
>>> + ninja \
>>> + paxmark \
>>
>> What is this needed for ?
>
> Seems like it also can be dropped.
>
>>> + perl \
>>> + pulseaudio-dev \
>>> + python3 \
>>> + py3-sphinx \
>>> + shadow \
>>
>> Is this really needed ?
>
> See:
> https://www.spinics.net/lists/kvm/msg231556.html
>
> I can remove the superfluous packages when picking up the patch, no need
> to respin just because of this.
>
> Thomas
>
>
You can refer to my post earlier this January for a "minimal" Alpine
Linux build, if you wish.
My goal was to find the smallest set of packages possible without
passing any explicit configure flags.
I wonder if it's worth having layered "core build" and "test build"
images so that we can smoke test the minimalistic build from time to
time -- I seem to recall Dan posting information about a dependency
management tool for Dockerfiles, but I admit I didn't look too closely
at what problem that solves, exactly.
--js
next prev parent reply other threads:[~2021-01-27 12:56 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 6:37 [PATCH v2 0/9] Alpine Linux build fix and CI pipeline Jiaxun Yang
2021-01-18 6:38 ` [PATCH v2 1/9] configure: Add sys/timex.h to probe clock_adjtime Jiaxun Yang
2021-01-18 6:38 ` [PATCH v2 2/9] libvhost-user: Include poll.h instead of sys/poll.h Jiaxun Yang
2021-01-18 9:41 ` Philippe Mathieu-Daudé
2021-01-18 6:38 ` [PATCH v2 3/9] osdep.h: Remove <sys/signal.h> include Jiaxun Yang
2021-01-18 9:41 ` Philippe Mathieu-Daudé
2021-01-18 6:38 ` [PATCH v2 4/9] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE Jiaxun Yang
2021-01-18 9:44 ` Philippe Mathieu-Daudé
2021-01-18 6:38 ` [PATCH v2 5/9] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE Jiaxun Yang
2021-01-18 9:44 ` Philippe Mathieu-Daudé
2021-01-18 6:38 ` [PATCH v2 6/9] tests: Rename PAGE_SIZE definitions Jiaxun Yang
2021-01-18 9:47 ` Philippe Mathieu-Daudé
2021-01-18 6:38 ` [PATCH v2 7/9] accel/kvm: avoid using predefined PAGE_SIZE Jiaxun Yang
2021-01-18 6:38 ` [PATCH v2 8/9] tests/docker: Add dockerfile for Alpine Linux Jiaxun Yang
2021-01-18 10:33 ` Daniel P. Berrangé
2021-01-19 13:41 ` Thomas Huth
2021-01-19 14:18 ` Daniel P. Berrangé
2021-01-26 21:38 ` John Snow [this message]
2021-01-27 9:58 ` Daniel P. Berrangé
2021-01-27 19:22 ` John Snow
2021-01-18 6:38 ` [PATCH v2 9/9] gitlab-ci: Add alpine to pipeline Jiaxun Yang
2021-01-18 10:11 ` Daniel P. Berrangé
2021-01-18 10:22 ` Thomas Huth
2021-01-18 10:26 ` Daniel P. Berrangé
2021-01-18 13:37 ` Jiaxun Yang
2021-01-18 14:44 ` Thomas Huth
2021-01-18 14:50 ` Daniel P. Berrangé
2021-01-18 15:12 ` Thomas Huth
2021-01-19 11:49 ` Thomas Huth
2021-01-18 7:06 ` [PATCH v2 0/9] Alpine Linux build fix and CI pipeline no-reply
2021-01-18 8:02 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551e153e-34da-28bd-c67f-d2a688ad987b@redhat.com \
--to=jsnow@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alistair@alistair23.me \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=fam@euphon.net \
--cc=groug@kaod.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
--cc=viktor.prutyanov@phystech.edu \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).