From mboxrd@z Thu Jan  1 00:00:00 1970
From: Waiman Long <waiman.long@hp.com>
Subject: Re: [PATCH v16 08/14] pvqspinlock: Implement simple paravirt support
 for the qspinlock
Date: Mon, 04 May 2015 13:15:52 -0400
Message-ID: <5547A948.5050406@hp.com>
References: <1429901803-29771-1-git-send-email-Waiman.Long@hp.com> <1429901803-29771-9-git-send-email-Waiman.Long@hp.com> <20150504142017.GK23123@twins.programming.kicks-ass.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>, linux-arch@vger.kernel.org,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	xen-devel@lists.xenproject.org, kvm@vger.kernel.org,
	Paolo Bonzini <paolo.bonzini@gmail.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Rik van Riel <riel@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	David Vrabel <david.vrabel@citrix.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Daniel J Blueman <daniel@numascale.com>,
	Scott J Norton <scott.norton@hp.com>,
	Douglas Hatch <doug.hatch@hp.com>
To: Peter Zijlstra <peterz@infradead.org>
Return-path: <linux-arch-owner@vger.kernel.org>
In-Reply-To: <20150504142017.GK23123@twins.programming.kicks-ass.net>
Sender: linux-arch-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 05/04/2015 10:20 AM, Peter Zijlstra wrote:
> I changed it to the below; I've not gotten around to compiling or even
> running it yet :-(
>
> The biggest change is the pv_hash/pv_unhash functions, which I've
> rewritten to hopefully be clearer (and also hopefully not wrecked them).
> I took out the cacheline sized structure which takes out that double
> loop and simplifies things. I've also added some comments which
> hopefully explain how/why we ended up with this exact scheme.
>
> I've also moved the __pv_queue_spin_unlock() function to the tail, such
> that we keep the 'wait'/'kick' order for both node and head.
>
> In any case, like I just wrote on the other email, I've stuck some
> things in my queue (up to and including patch 11) and if it all works
> out we can continue from there.
>
> ---
> Subject: pvqspinlock: Implement simple paravirt support for the qspinlock
> From: Waiman Long<Waiman.Long@hp.com>
> Date: Fri, 24 Apr 2015 14:56:37 -0400
>
> Provide a separate (second) version of the spin_lock_slowpath for
> paravirt along with a special unlock path.
>
> The second slowpath is generated by adding a few pv hooks to the
> normal slowpath, but where those will compile away for the native
> case, they expand into special wait/wake code for the pv version.
>
> The actual MCS queue can use extra storage in the mcs_nodes[] array to
> keep track of state and therefore uses directed wakeups.
>
> The head contender has no such storage directly visible to the
> unlocker.  So the unlocker searches a hash table with open addressing
> using a simple binary Galois linear feedback shift register.

I am fine with the change as it makes it simpler. BTW, I just saw a 
build error mail. That should be fixed easily with some minor edit.

Cheers,
Longman