From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v3 17/18] x86/kvm/tsc: Drop extra barrier and use rdtsc_ordered in kvmclock Date: Wed, 17 Jun 2015 15:31:27 +0200 Message-ID: <558176AF.8070109@redhat.com> References: <678981cc4761fb38a793c217c9cac42503cf3719.1434501121.git.luto@kernel.org> <558125FC.7010007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Borislav Petkov , Peter Zijlstra , John Stultz , linux-kernel@vger.kernel.org, Len Brown , Huang Rui , Denys Vlasenko , kvm@vger.kernel.org, Ralf Baechle , Radim Krcmar , Marcelo Tosatti To: Andy Lutomirski , x86@kernel.org Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:34338 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443AbbFQNba (ORCPT ); Wed, 17 Jun 2015 09:31:30 -0400 In-Reply-To: <558125FC.7010007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 17/06/2015 09:47, Paolo Bonzini wrote: > > > On 17/06/2015 02:36, Andy Lutomirski wrote: >> __pvclock_read_cycles had an unnecessary barrier. Get rid of that >> barrier and clean up the code by just using rdtsc_ordered(). >> >> Cc: Paolo Bonzini >> Cc: Radim Krcmar >> Cc: Marcelo Tosatti >> Cc: kvm@vger.kernel.org >> Signed-off-by: Andy Lutomirski >> --- >> >> I'm hoping to get an ack for this to go in through -tip. (Arguably >> I'm the maintainer of this code given how it's used, but I should >> still ask for an ack.) >> >> arch/x86/include/asm/pvclock.h | 21 ++++++++++++--------- >> 1 file changed, 12 insertions(+), 9 deletions(-) > > Can you send a URL to the rest of the series? I've never even seen v1 > or v2 so I have no idea of what this is about. Ah, it was sent to the KVM list, just not CCed to me. :) Sorry, that's what you get when your unread message count does not fit in three digits anymore. Paolo