From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: emulate reserved nops from 0f/18 to 0f/1f
Date: Mon, 18 May 2020 19:37:08 +0200 [thread overview]
Message-ID: <57d9da9b-00ec-3fe0-c69a-f7f00c68a90d@redhat.com> (raw)
In-Reply-To: <20200518160720.GB3632@linux.intel.com>
On 18/05/20 18:07, Sean Christopherson wrote:
> On Fri, May 15, 2020 at 12:19:19PM -0400, Paolo Bonzini wrote:
>> Instructions starting with 0f18 up to 0f1f are reserved nops, except those
>> that were assigned to MPX.
> Well, they're probably reserved NOPs again :-D.
So are you suggesting adding them back to the list as well?
>> These include the endbr markers used by CET.
> And RDSPP. Wouldn't it make sense to treat RDSPP as a #UD even though it's
> a NOP if CET is disabled? The logic being that a sane guest will execute
> RDSSP iff CET is enabled, and in that case it'd be better to inject a #UD
> than to silently break the guest.
We cannot assume that guests will bother checking CPUID before invoking
RDSPP. This is especially true userspace, which needs to check if CET
is enable for itself and can only use RDSPP to do so.
Paolo
next prev parent reply other threads:[~2020-05-18 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 16:19 [PATCH] KVM: x86: emulate reserved nops from 0f/18 to 0f/1f Paolo Bonzini
2020-05-18 16:07 ` Sean Christopherson
2020-05-18 17:37 ` Paolo Bonzini [this message]
2020-05-19 6:02 ` Sean Christopherson
2020-05-19 7:43 ` Paolo Bonzini
2020-05-19 7:55 ` Sean Christopherson
2020-05-19 8:06 ` Paolo Bonzini
2020-05-19 15:32 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57d9da9b-00ec-3fe0-c69a-f7f00c68a90d@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).