From: Paolo Bonzini <pbonzini@redhat.com>
To: Ben Gardon <bgardon@google.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org
Cc: Peter Xu <peterx@redhat.com>, Andrew Jones <drjones@redhat.com>,
Peter Shier <pshier@google.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Thomas Huth <thuth@redhat.com>, Jacob Xu <jacobhxu@google.com>,
Makarand Sonare <makarandsonare@google.com>
Subject: Re: [PATCH 0/6] KVM: selftests: Perf test cleanups and memslot modification test
Date: Mon, 18 Jan 2021 19:18:45 +0100 [thread overview]
Message-ID: <583b1769-0f35-8f77-8570-2cc41612e4d4@redhat.com> (raw)
In-Reply-To: <20210112214253.463999-1-bgardon@google.com>
On 12/01/21 22:42, Ben Gardon wrote:
> This series contains a few cleanups that didn't make it into previous
> series, including some cosmetic changes and small bug fixes. The series
> also lays the groundwork for a memslot modification test which stresses
> the memslot update and page fault code paths in an attempt to expose races.
>
> Tested: dirty_log_perf_test, memslot_modification_stress_test, and
> demand_paging_test were run, with all the patches in this series
> applied, on an Intel Skylake machine.
>
> echo Y > /sys/module/kvm/parameters/tdp_mmu; \
> ./memslot_modification_stress_test -i 1000 -v 64 -b 1G; \
> ./memslot_modification_stress_test -i 1000 -v 64 -b 64M -o; \
> ./dirty_log_perf_test -v 64 -b 1G; \
> ./dirty_log_perf_test -v 64 -b 64M -o; \
> ./demand_paging_test -v 64 -b 1G; \
> ./demand_paging_test -v 64 -b 64M -o; \
> echo N > /sys/module/kvm/parameters/tdp_mmu; \
> ./memslot_modification_stress_test -i 1000 -v 64 -b 1G; \
> ./memslot_modification_stress_test -i 1000 -v 64 -b 64M -o; \
> ./dirty_log_perf_test -v 64 -b 1G; \
> ./dirty_log_perf_test -v 64 -b 64M -o; \
> ./demand_paging_test -v 64 -b 1G; \
> ./demand_paging_test -v 64 -b 64M -o
>
> The tests behaved as expected, and fixed the problem of the
> population stage being skipped in dirty_log_perf_test. This can be
> seen in the output, with the population stage taking about the time
> dirty pass 1 took and dirty pass 1 falling closer to the times for
> the other passes.
>
> Note that when running these tests, the -o option causes the test to take
> much longer as the work each vCPU must do increases proportional to the
> number of vCPUs.
>
> You can view this series in Gerrit at:
> https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/7216
>
> Ben Gardon (6):
> KVM: selftests: Rename timespec_diff_now to timespec_elapsed
> KVM: selftests: Avoid flooding debug log while populating memory
> KVM: selftests: Convert iterations to int in dirty_log_perf_test
> KVM: selftests: Fix population stage in dirty_log_perf_test
> KVM: selftests: Add option to overlap vCPU memory access
> KVM: selftests: Add memslot modification stress test
>
> tools/testing/selftests/kvm/.gitignore | 1 +
> tools/testing/selftests/kvm/Makefile | 1 +
> .../selftests/kvm/demand_paging_test.c | 40 +++-
> .../selftests/kvm/dirty_log_perf_test.c | 72 +++---
> .../selftests/kvm/include/perf_test_util.h | 4 +-
> .../testing/selftests/kvm/include/test_util.h | 2 +-
> .../selftests/kvm/lib/perf_test_util.c | 25 ++-
> tools/testing/selftests/kvm/lib/test_util.c | 2 +-
> .../kvm/memslot_modification_stress_test.c | 211 ++++++++++++++++++
> 9 files changed, 307 insertions(+), 51 deletions(-)
> create mode 100644 tools/testing/selftests/kvm/memslot_modification_stress_test.c
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2021-01-18 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 21:42 [PATCH 0/6] KVM: selftests: Perf test cleanups and memslot modification test Ben Gardon
2021-01-12 21:42 ` [PATCH 1/6] KVM: selftests: Rename timespec_diff_now to timespec_elapsed Ben Gardon
2021-01-12 21:42 ` [PATCH 2/6] KVM: selftests: Avoid flooding debug log while populating memory Ben Gardon
2021-01-13 7:37 ` Thomas Huth
2021-01-16 0:00 ` Sean Christopherson
2021-01-12 21:42 ` [PATCH 3/6] KVM: selftests: Convert iterations to int in dirty_log_perf_test Ben Gardon
2021-01-13 7:39 ` Thomas Huth
2021-01-12 21:42 ` [PATCH 4/6] KVM: selftests: Fix population stage " Ben Gardon
2021-01-16 0:02 ` Sean Christopherson
2021-01-12 21:42 ` [PATCH 5/6] KVM: selftests: Add option to overlap vCPU memory access Ben Gardon
2021-01-12 21:42 ` [PATCH 6/6] KVM: selftests: Add memslot modification stress test Ben Gardon
2021-01-16 0:10 ` Sean Christopherson
2021-01-18 18:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583b1769-0f35-8f77-8570-2cc41612e4d4@redhat.com \
--to=pbonzini@redhat.com \
--cc=bgardon@google.com \
--cc=drjones@redhat.com \
--cc=jacobhxu@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=makarandsonare@google.com \
--cc=peterx@redhat.com \
--cc=pshier@google.com \
--cc=sean.j.christopherson@intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).