From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2752C73C46 for ; Tue, 9 Jul 2019 12:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE1F721537 for ; Tue, 9 Jul 2019 12:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726345AbfGIMsI (ORCPT ); Tue, 9 Jul 2019 08:48:08 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:28978 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfGIMsI (ORCPT ); Tue, 9 Jul 2019 08:48:08 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x69Cix0O041988; Tue, 9 Jul 2019 08:47:40 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tmrd6yhpm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2019 08:47:40 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x69CdLPN006602; Tue, 9 Jul 2019 12:47:39 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma01wdc.us.ibm.com with ESMTP id 2tjk96cyry-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jul 2019 12:47:39 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x69Clcj140829346 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jul 2019 12:47:38 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB0B6AC05F; Tue, 9 Jul 2019 12:47:38 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A6121AC060; Tue, 9 Jul 2019 12:47:38 +0000 (GMT) Received: from [9.56.58.103] (unknown [9.56.58.103]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Tue, 9 Jul 2019 12:47:38 +0000 (GMT) Subject: Re: [RFC v2 5/5] vfio-ccw: Update documentation for csch/hsch To: Cornelia Huck Cc: farman@linux.ibm.com, pasic@linux.ibm.com, linux-s390@vger.kernel.org, kvm@vger.kernel.org References: <20190709121445.1d7bf8ed.cohuck@redhat.com> From: Farhan Ali Message-ID: <58ece8ce-a155-3353-71f1-26e242db5c55@linux.ibm.com> Date: Tue, 9 Jul 2019 08:47:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20190709121445.1d7bf8ed.cohuck@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-09_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907090152 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 07/09/2019 06:14 AM, Cornelia Huck wrote: > On Mon, 8 Jul 2019 16:10:38 -0400 > Farhan Ali wrote: > >> We now support CLEAR SUBCHANNEL and HALT SUBCHANNEL >> via ccw_cmd_region. >> > > Thanks, I forgot about this. > > Fixes: d5afd5d135c8 ("vfio-ccw: add handling for async channel instructions") > I don't know if this warranted a fixes tag but I will add it. >> Signed-off-by: Farhan Ali >> --- >> Documentation/s390/vfio-ccw.rst | 31 ++++++++++++++++++++++++++++--- >> 1 file changed, 28 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/s390/vfio-ccw.rst b/Documentation/s390/vfio-ccw.rst >> index 1f6d0b5..40e4110 100644 >> --- a/Documentation/s390/vfio-ccw.rst >> +++ b/Documentation/s390/vfio-ccw.rst >> @@ -180,6 +180,13 @@ The process of how these work together. >> add it to an iommu_group and a vfio_group. Then we could pass through >> the mdev to a guest. >> >> + >> +VFIO-CCW Regions >> +---------------- >> + >> +The vfio-ccw driver exposes MMIO regions to accept requests from and return >> +results to userspace. >> + >> vfio-ccw I/O region >> ------------------- >> >> @@ -205,6 +212,25 @@ irb_area stores the I/O result. >> >> ret_code stores a return code for each access of the region. >> >> +This region is always available. >> + >> +vfio-ccw cmd region >> +------------------- >> + >> +The vfio-ccw cmd region is used to accept asynchronous instructions >> +from userspace. >> + >> +#define VFIO_CCW_ASYNC_CMD_HSCH (1 << 0) >> +#define VFIO_CCW_ASYNC_CMD_CSCH (1 << 1) >> +struct ccw_cmd_region { >> + __u32 command; >> + __u32 ret_code; >> +} __packed; >> + >> +This region is exposed via region type VFIO_REGION_SUBTYPE_CCW_ASYNC_CMD. >> + >> +CLEAR SUBCHANNEL and HALT SUBCHANNEL currently uses this region. > > "Currently, CLEAR SUBCHANNEL and HALT SUBCHANNEL use this region". ? > This sounds better to me :) >> + >> vfio-ccw operation details >> -------------------------- >> >> @@ -306,9 +332,8 @@ Together with the corresponding work in QEMU, we can bring the passed >> through DASD/ECKD device online in a guest now and use it as a block >> device. >> >> -While the current code allows the guest to start channel programs via >> -START SUBCHANNEL, support for HALT SUBCHANNEL or CLEAR SUBCHANNEL is >> -not yet implemented. >> +The current code allows the guest to start channel programs via >> +START SUBCHANNEL, and supports HALT SUBCHANNEL or CLEAR SUBCHANNEL. > > "The current code allows the guest to start channel programs via START > SUBCHANNEL, and to issue HALT SUBCHANNEL and CLEAR SUBCHANNEL." ? > Same. I will update with the changes you requested. >> >> vfio-ccw supports classic (command mode) channel I/O only. Transport >> mode (HPF) is not supported. > > Thanks for taking a look. Thanks Farhan