From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: thuth@redhat.com, david@redhat.com, cohuck@redhat.com,
linux-s390@vger.kernel.org
Subject: Re: [PATCH v8 1/4] KVM: s390: Add new reset vcpu API
Date: Thu, 30 Jan 2020 10:58:57 +0100 [thread overview]
Message-ID: <59091e9d-5a4d-6151-bb4d-0f6e46b93808@de.ibm.com> (raw)
In-Reply-To: <20200129200312.3200-2-frankja@linux.ibm.com>
On 29.01.20 21:03, Janosch Frank wrote:
[...]> +static void kvm_arch_vcpu_ioctl_initial_reset(struct kvm_vcpu *vcpu)
> +{
> + /* Initial reset is a superset of the normal reset */
> + kvm_arch_vcpu_ioctl_normal_reset(vcpu);
> +
> + /* this equals initial cpu reset in pop, but we don't switch to ESA */
> + vcpu->arch.sie_block->gpsw.mask = 0;
> + vcpu->arch.sie_block->gpsw.addr = 0;
> + kvm_s390_set_prefix(vcpu, 0);
> + kvm_s390_set_cpu_timer(vcpu, 0);
> + vcpu->arch.sie_block->ckc = 0;
> + vcpu->arch.sie_block->todpr = 0;
> + memset(vcpu->arch.sie_block->gcr, 0, sizeof(vcpu->arch.sie_block->gcr));
> + vcpu->arch.sie_block->gcr[0] = CR0_INITIAL_MASK;
> + vcpu->arch.sie_block->gcr[14] = CR14_INITIAL_MASK;
> + /* make sure the new fpc will be lazily loaded */
> + save_fpu_regs();
see my other patch. We should rebase this series and fix it here as well
> + current->thread.fpu.fpc = 0;
> + vcpu->arch.sie_block->gbea = 1;
> + vcpu->arch.sie_block->pp = 0;
> + vcpu->arch.sie_block->fpf &= ~FPF_BPBC;
> +}
> +
> +static void kvm_arch_vcpu_ioctl_clear_reset(struct kvm_vcpu *vcpu)
> +{
> + struct kvm_sync_regs *regs = &vcpu->run->s.regs;
> +
> + /* Clear reset is a superset of the initial reset */
> + kvm_arch_vcpu_ioctl_initial_reset(vcpu);
> +
> + memset(®s->gprs, 0, sizeof(regs->gprs));
> + memset(®s->vrs, 0, sizeof(regs->vrs));
> + memset(®s->acrs, 0, sizeof(regs->acrs));
> +
> + regs->etoken = 0;
> + regs->etoken_extension = 0;
> +
> + memset(®s->gscb, 0, sizeof(regs->gscb));
> + if (MACHINE_HAS_GS) {
> + preempt_disable();
> + __ctl_set_bit(2, 4);
> + if (current->thread.gs_cb) {
> + vcpu->arch.host_gscb = current->thread.gs_cb;
> + save_gs_cb(vcpu->arch.host_gscb);
> + }
> + if (vcpu->arch.gs_enabled) {
> + current->thread.gs_cb = (struct gs_cb *)
> + &vcpu->run->s.regs.gscb;
> + restore_gs_cb(current->thread.gs_cb);
> + }
> + preempt_enable();
> + }
I think this hunk can go? (same reason as for floating point)
Other than that this looks good.
next prev parent reply other threads:[~2020-01-30 9:59 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 20:03 [PATCH v8 0/4] KVM: s390: Add new reset vcpu API Janosch Frank
2020-01-29 20:03 ` [PATCH v8 1/4] " Janosch Frank
2020-01-30 8:55 ` [PATCH/FIXUP FOR STABLE BEFORE THIS SERIES] KVM: s390: do not clobber user space fpc during guest reset Christian Borntraeger
2020-01-30 9:49 ` David Hildenbrand
2020-01-30 10:39 ` Cornelia Huck
2020-01-30 10:56 ` Thomas Huth
2020-01-30 11:07 ` Christian Borntraeger
2020-01-30 11:01 ` Christian Borntraeger
2020-01-30 11:14 ` Christian Borntraeger
2020-01-30 11:20 ` David Hildenbrand
2020-01-30 11:27 ` Christian Borntraeger
2020-01-30 11:42 ` [PATCH v2] KVM: s390: do not clobber user space registers during guest reset/store status Christian Borntraeger
2020-01-30 11:44 ` Christian Borntraeger
2020-01-30 12:01 ` Christian Borntraeger
2020-01-30 12:38 ` David Hildenbrand
2020-01-30 9:00 ` [PATCH v8 1/4] KVM: s390: Add new reset vcpu API Thomas Huth
2020-01-30 9:58 ` Christian Borntraeger [this message]
2020-01-29 20:03 ` [PATCH v8 2/4] selftests: KVM: Add fpu and one reg set/get library functions Janosch Frank
2020-01-30 10:36 ` Thomas Huth
2020-01-30 13:55 ` Andrew Jones
2020-01-30 14:10 ` Janosch Frank
2020-01-30 14:30 ` Andrew Jones
2020-01-30 14:58 ` Janosch Frank
2020-01-30 15:04 ` Andrew Jones
2020-01-29 20:03 ` [PATCH v8 3/4] selftests: KVM: s390x: Add reset tests Janosch Frank
2020-01-30 10:51 ` Thomas Huth
2020-01-30 11:32 ` Janosch Frank
2020-01-30 11:36 ` Thomas Huth
2020-01-29 20:03 ` [PATCH v8 4/4] selftests: KVM: testing the local IRQs resets Janosch Frank
2020-01-30 10:55 ` Cornelia Huck
2020-01-30 11:18 ` Janosch Frank
2020-01-30 11:28 ` Cornelia Huck
2020-01-30 11:34 ` Janosch Frank
2020-01-30 11:10 ` Thomas Huth
2020-01-30 11:33 ` Janosch Frank
2020-01-30 9:10 ` [PATCH] KVM: s390: Cleanup initial cpu reset Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59091e9d-5a4d-6151-bb4d-0f6e46b93808@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).