From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD24C04FF3 for ; Mon, 24 May 2021 12:28:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 924F061370 for ; Mon, 24 May 2021 12:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232848AbhEXMaZ (ORCPT ); Mon, 24 May 2021 08:30:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54843 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232476AbhEXMaX (ORCPT ); Mon, 24 May 2021 08:30:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621859335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P4X7Q6cOoCe0hTVDV5ljv+76y3e0rtVo1k13v34nVV8=; b=CwKhxLXcawjifn4n8xpdgSNV9X7cvY+l/4sTEooDyzzv7Aupct/tZUbNp73cKRQmzTXGlT 5sz0LMhSqlNuoUzRvZx5NfIBt0Ocm2KN72z6l1tee0TMARSeB/AuFiEru/teIhZpfFtDsy u427oJ+gIO/PHXW+HYajuItwLo2b2H8= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-QTxMNqi7OqSqrFETDfNmGw-1; Mon, 24 May 2021 08:28:48 -0400 X-MC-Unique: QTxMNqi7OqSqrFETDfNmGw-1 Received: by mail-ej1-f72.google.com with SMTP id la2-20020a170906ad82b02903d4bcc8de3bso7493026ejb.4 for ; Mon, 24 May 2021 05:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=P4X7Q6cOoCe0hTVDV5ljv+76y3e0rtVo1k13v34nVV8=; b=JVgK0jJUvPHqWYGemOhkS8wHP/MPdGNzcN+AH1t9Oj8XKMtS0AHp1hMvWz+lfhBh7C 5Vc9Uly86annlGYuQ6W0hJlATOTx4BWndbW81HIdT3iabkEMpDk1zvMtOBbn7vxvlyBB I7TkhLPKlpfjdBDJjPMkxkk0jQVkksTJrAFkmMMX478NDpm4tpL1B+mmjzUTOV4nkBlq 9XK70hOv0h76ou/5T0mjGXVoiZklkrnQzg6mg3ZoR5ZCSeVgQz6EzeS0M7OZPapsIBWZ 2a2hLsIfs6lzBKTe8xBROLwb1hyn9de3z0k6nM0tpovgojaxZSAdGL/Ce9Zp7m3+zUcR DFfQ== X-Gm-Message-State: AOAM531LJ/7ziG+52tlDpiEcgjNPvoGoiDcDZMvNdmxMcL+mSaBXy1tE aOrQSyDmxjgDxxG2/mnwIUz2i66lYq7B+p9PYVJNf2Ir6vUmW/Fbo2hH1ESyZKSp2YIebVnHe5B Yslm6bpyuvOnk X-Received: by 2002:a17:906:6b96:: with SMTP id l22mr22720227ejr.456.1621859327381; Mon, 24 May 2021 05:28:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6VGkaZuxjCsNKEVJMf+xCBpZGuX4FX7erKeA5K1DM9WApJulSm4iVn6lzGshwE6t7/hh/NQ== X-Received: by 2002:a17:906:6b96:: with SMTP id l22mr22720186ejr.456.1621859327222; Mon, 24 May 2021 05:28:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k11sm7899534ejc.94.2021.05.24.05.28.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 05:28:46 -0700 (PDT) Subject: Re: [PATCH v2 2/7] KVM: X86: Use _BITUL() macro in UAPI headers To: Joe Richey , trivial@kernel.org Cc: Joe Richey , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Mark Rutland , Lorenzo Pieralisi , Mauro Carvalho Chehab , Zhangfei Gao , Zhou Wang , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , Andi Kleen , "Chang S. Bae" , Sasha Levin , Peter Xu , Lei Cao , Daniel Lezcano , "Rafael J. Wysocki" , Ulf Hansson , Jean-Philippe Brucker , Zaibo Xu , Kenneth Lee , Jonathan Cameron , Hans Verkuil , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-accelerators@lists.ozlabs.org References: <20210520104343.317119-1-joerichey94@gmail.com> <20210521085849.37676-1-joerichey94@gmail.com> <20210521085849.37676-3-joerichey94@gmail.com> From: Paolo Bonzini Message-ID: <59754ef1-c49d-11a6-30ba-8b938a6bb45d@redhat.com> Date: Mon, 24 May 2021 14:28:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210521085849.37676-3-joerichey94@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 21/05/21 10:58, Joe Richey wrote: > From: Joe Richey > > Replace BIT() in KVM's UPAI header with _BITUL(). BIT() is not defined > in the UAPI headers and its usage may cause userspace build errors. > > Fixes: fb04a1eddb1a ("KVM: X86: Implement ring-based dirty memory tracking") > Signed-off-by: Joe Richey > --- > include/uapi/linux/kvm.h | 5 +++-- > tools/include/uapi/linux/kvm.h | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 3fd9a7e9d90c..79d9c44d1ad7 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -8,6 +8,7 @@ > * Note: you must update KVM_API_VERSION if you change this interface. > */ > > +#include > #include > #include > #include > @@ -1879,8 +1880,8 @@ struct kvm_hyperv_eventfd { > * conversion after harvesting an entry. Also, it must not skip any > * dirty bits, so that dirty bits are always harvested in sequence. > */ > -#define KVM_DIRTY_GFN_F_DIRTY BIT(0) > -#define KVM_DIRTY_GFN_F_RESET BIT(1) > +#define KVM_DIRTY_GFN_F_DIRTY _BITUL(0) > +#define KVM_DIRTY_GFN_F_RESET _BITUL(1) > #define KVM_DIRTY_GFN_F_MASK 0x3 > > /* > diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h > index 3fd9a7e9d90c..79d9c44d1ad7 100644 > --- a/tools/include/uapi/linux/kvm.h > +++ b/tools/include/uapi/linux/kvm.h > @@ -8,6 +8,7 @@ > * Note: you must update KVM_API_VERSION if you change this interface. > */ > > +#include > #include > #include > #include > @@ -1879,8 +1880,8 @@ struct kvm_hyperv_eventfd { > * conversion after harvesting an entry. Also, it must not skip any > * dirty bits, so that dirty bits are always harvested in sequence. > */ > -#define KVM_DIRTY_GFN_F_DIRTY BIT(0) > -#define KVM_DIRTY_GFN_F_RESET BIT(1) > +#define KVM_DIRTY_GFN_F_DIRTY _BITUL(0) > +#define KVM_DIRTY_GFN_F_RESET _BITUL(1) > #define KVM_DIRTY_GFN_F_MASK 0x3 > > /* > Queued thi sone, thanks. Paolo