From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E9D1C43603 for ; Mon, 9 Dec 2019 16:44:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B949207FF for ; Mon, 9 Dec 2019 16:44:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726769AbfLIQob (ORCPT ); Mon, 9 Dec 2019 11:44:31 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:14932 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726197AbfLIQob (ORCPT ); Mon, 9 Dec 2019 11:44:31 -0500 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB9GMLQ3132821 for ; Mon, 9 Dec 2019 11:44:30 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2wrt58mvsc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Dec 2019 11:44:30 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Dec 2019 16:44:28 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 9 Dec 2019 16:44:25 -0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xB9GiOZO31523058 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 9 Dec 2019 16:44:24 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2C25AAE055; Mon, 9 Dec 2019 16:44:24 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EAD05AE045; Mon, 9 Dec 2019 16:44:23 +0000 (GMT) Received: from oc3016276355.ibm.com (unknown [9.152.222.89]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 9 Dec 2019 16:44:23 +0000 (GMT) Subject: Re: [kvm-unit-tests PATCH v3 4/9] s390x: export the clock get_clock_ms() utility To: Thomas Huth , kvm@vger.kernel.org Cc: linux-s390@vger.kernel.org, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com References: <1575649588-6127-1-git-send-email-pmorel@linux.ibm.com> <1575649588-6127-5-git-send-email-pmorel@linux.ibm.com> From: Pierre Morel Date: Mon, 9 Dec 2019 17:44:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19120916-0008-0000-0000-0000033F32C7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19120916-0009-0000-0000-00004A5E60AE Message-Id: <59e71889-66e5-306b-5a63-82fada3ef7ec@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-09_04:2019-12-09,2019-12-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 adultscore=0 spamscore=0 impostorscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912090141 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2019-12-09 12:42, Thomas Huth wrote: > On 06/12/2019 17.26, Pierre Morel wrote: >> To serve multiple times, the function get_clock_ms() is moved >> from intercept.c test to the new file asm/time.h. >> >> Signed-off-by: Pierre Morel >> Reviewed-by: David Hildenbrand >> --- >> lib/s390x/asm/time.h | 27 +++++++++++++++++++++++++++ >> s390x/intercept.c | 11 +---------- >> 2 files changed, 28 insertions(+), 10 deletions(-) >> create mode 100644 lib/s390x/asm/time.h >> >> diff --git a/lib/s390x/asm/time.h b/lib/s390x/asm/time.h >> new file mode 100644 >> index 0000000..b07ccbd >> --- /dev/null >> +++ b/lib/s390x/asm/time.h >> @@ -0,0 +1,27 @@ >> +/* >> + * Clock utilities for s390 >> + * >> + * Authors: >> + * Thomas Huth >> + * >> + * Copied from the s390/intercept test by: >> + * Pierre Morel >> + * >> + * This code is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2. >> + */ >> +#ifndef _ASM_S390X_TIME_H_ >> +#define _ASM_S390X_TIME_H_ >> + >> +static inline uint64_t get_clock_ms(void) >> +{ >> + uint64_t clk; >> + >> + asm volatile(" stck %0 " : : "Q"(clk) : "memory"); >> + >> + /* Bit 51 is incrememented each microsecond */ >> + return (clk >> (63 - 51)) / 1000; >> +} >> + >> + > > Please remove one of the two empty lines. yes, of course, thanks. > > With that cosmetic nit fixed: > Reviewed-by: Thomas Huth > Thanks, Pierre -- Pierre Morel IBM Lab Boeblingen