From: piaojun <piaojun@huawei.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-nvdimm@lists.01.org>, kbuild test robot <lkp@intel.com>,
<kvm@vger.kernel.org>, <miklos@szeredi.hu>,
<virtio-fs@redhat.com>,
"Sebastien Boeuf" <sebastien.boeuf@intel.com>
Subject: Re: [Virtio-fs] [PATCH 04/19] virtio: Implement get_shm_region for PCI transport
Date: Tue, 27 Aug 2019 17:41:38 +0800 [thread overview]
Message-ID: <5D64FAD2.2050906@huawei.com> (raw)
In-Reply-To: <20190826130607.GB3561@redhat.com>
On 2019/8/26 21:06, Vivek Goyal wrote:
> On Mon, Aug 26, 2019 at 09:43:08AM +0800, piaojun wrote:
>
> [..]
>>> +static bool vp_get_shm_region(struct virtio_device *vdev,
>>> + struct virtio_shm_region *region, u8 id)
>>> +{
>>> + struct virtio_pci_device *vp_dev = to_vp_device(vdev);
>>> + struct pci_dev *pci_dev = vp_dev->pci_dev;
>>> + u8 bar;
>>> + u64 offset, len;
>>> + phys_addr_t phys_addr;
>>> + size_t bar_len;
>>> + char *bar_name;
>>
>> 'char *bar_name' should be cleaned up to avoid compiling warning. And I
>> wonder if you mix tab and blankspace for code indent? Or it's just my
>> email display problem?
>
> Will get rid of now unused bar_name.
>
OK
> Generally git flags if there are tab/space issues. I did not see any. So
> if you see something, point it out and I will fix it.
>
cohuck found the same indent problem and pointed them in another email.
Jun
next prev parent reply other threads:[~2019-08-27 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190821175720.25901-1-vgoyal@redhat.com>
2019-08-21 17:57 ` [PATCH 04/19] virtio: Implement get_shm_region for PCI transport Vivek Goyal
2019-08-26 1:43 ` [Virtio-fs] " piaojun
2019-08-26 13:06 ` Vivek Goyal
2019-08-27 9:41 ` piaojun [this message]
2019-08-27 8:34 ` Cornelia Huck
2019-08-27 8:46 ` Cornelia Huck
2019-08-27 11:53 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 05/19] virtio: Implement get_shm_region for MMIO transport Vivek Goyal
2019-08-27 8:39 ` Cornelia Huck
2019-08-27 11:54 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D64FAD2.2050906@huawei.com \
--to=piaojun@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=miklos@szeredi.hu \
--cc=sebastien.boeuf@intel.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).