From: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "eric.auger@redhat.com" <eric.auger@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Linuxarm <linuxarm@huawei.com>,
"John Garry" <john.garry@huawei.com>,
"xuwei (O)" <xuwei5@huawei.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>
Subject: RE: [PATCH v7 2/6] vfio/type1: Check reserve region conflict and update iova list
Date: Thu, 4 Jul 2019 22:06:23 +0000 [thread overview]
Message-ID: <5FC3163CFD30C246ABAA99954A238FA83F2DDED5@lhreml524-mbs.china.huawei.com> (raw)
In-Reply-To: 20190703143427.2d63c15f@x1.home
> -----Original Message-----
> From: Shameerali Kolothum Thodi
> Sent: 04 July 2019 13:51
> To: 'Alex Williamson' <alex.williamson@redhat.com>
> Cc: eric.auger@redhat.com; kvm@vger.kernel.org;
> linux-kernel@vger.kernel.org; iommu@lists.linux-foundation.org; Linuxarm
> <linuxarm@huawei.com>; John Garry <john.garry@huawei.com>; xuwei (O)
> <xuwei5@huawei.com>; kevin.tian@intel.com
> Subject: RE: [PATCH v7 2/6] vfio/type1: Check reserve region conflict and
> update iova list
>
>
>
> > -----Original Message-----
> > From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On
> > Behalf Of Alex Williamson
> > Sent: 03 July 2019 21:34
> > To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
> > Cc: eric.auger@redhat.com; pmorel@linux.vnet.ibm.com;
> > kvm@vger.kernel.org; linux-kernel@vger.kernel.org;
> > iommu@lists.linux-foundation.org; Linuxarm <linuxarm@huawei.com>; John
> > Garry <john.garry@huawei.com>; xuwei (O) <xuwei5@huawei.com>;
> > kevin.tian@intel.com
> > Subject: Re: [PATCH v7 2/6] vfio/type1: Check reserve region conflict and
> > update iova list
> >
> > On Wed, 26 Jun 2019 16:12:44 +0100
> > Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> wrote:
> >
> > > This retrieves the reserved regions associated with dev group and
> > > checks for conflicts with any existing dma mappings. Also update
> > > the iova list excluding the reserved regions.
> > >
> > > Reserved regions with type IOMMU_RESV_DIRECT_RELAXABLE are
> > > excluded from above checks as they are considered as directly
> > > mapped regions which are known to be relaxable.
> > >
> > > Signed-off-by: Shameer Kolothum
> <shameerali.kolothum.thodi@huawei.com>
> > > ---
> > > drivers/vfio/vfio_iommu_type1.c | 96
> > +++++++++++++++++++++++++++++++++
> > > 1 file changed, 96 insertions(+)
> > >
> > > diff --git a/drivers/vfio/vfio_iommu_type1.c
> > b/drivers/vfio/vfio_iommu_type1.c
> > > index 970d1ec06aed..b6bfdfa16c33 100644
> > > --- a/drivers/vfio/vfio_iommu_type1.c
> > > +++ b/drivers/vfio/vfio_iommu_type1.c
> > > @@ -1559,6 +1641,7 @@ static int vfio_iommu_type1_attach_group(void
> > *iommu_data,
> > > phys_addr_t resv_msi_base;
> > > struct iommu_domain_geometry geo;
> > > LIST_HEAD(iova_copy);
> > > + LIST_HEAD(group_resv_regions);
> > >
> > > mutex_lock(&iommu->lock);
> > >
> > > @@ -1644,6 +1727,13 @@ static int vfio_iommu_type1_attach_group(void
> > *iommu_data,
> > > goto out_detach;
> > > }
> > >
> > > + iommu_get_group_resv_regions(iommu_group,
> &group_resv_regions);
> >
> > This can fail and should have an error case. I assume we'd fail the
> > group attach on failure. Thanks,
>
> Right. I will add the check. Do you think we should do the same in
> vfio_iommu_has_sw_msi()
> as well? (In fact, it looks like iommu_get_group_resv_regions() ret is not
> checked anywhere in
> kernel).
Ah..forgot the fact that patch 6/6 should take care of vfio_iommu_has_sw_msi()
case as we are removing the duplicate iommu_get_group_resv_regions() there.
Thanks,
Shameer
next prev parent reply other threads:[~2019-07-04 22:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 15:12 [PATCH v7 0/6] vfio/type1: Add support for valid iova list management Shameer Kolothum
2019-06-26 15:12 ` [PATCH v7 1/6] vfio/type1: Introduce iova list and add iommu aperture validity check Shameer Kolothum
2019-07-03 20:34 ` Alex Williamson
2019-07-04 12:36 ` Shameerali Kolothum Thodi
2019-07-07 15:02 ` Auger Eric
2019-07-08 7:07 ` Shameerali Kolothum Thodi
2019-06-26 15:12 ` [PATCH v7 2/6] vfio/type1: Check reserve region conflict and update iova list Shameer Kolothum
2019-07-03 20:34 ` Alex Williamson
2019-07-04 12:51 ` Shameerali Kolothum Thodi
2019-07-05 12:09 ` Auger Eric
2019-07-08 6:59 ` Shameerali Kolothum Thodi
2019-07-04 22:06 ` Shameerali Kolothum Thodi [this message]
2019-07-07 15:02 ` Auger Eric
2019-06-26 15:12 ` [PATCH v7 3/6] vfio/type1: Update iova list on detach Shameer Kolothum
2019-07-03 20:34 ` Alex Williamson
2019-07-04 12:53 ` Shameerali Kolothum Thodi
2019-07-07 15:03 ` Auger Eric
2019-07-08 7:10 ` Shameerali Kolothum Thodi
2019-06-26 15:12 ` [PATCH v7 4/6] vfio/type1: check dma map request is within a valid iova range Shameer Kolothum
2019-07-07 15:03 ` Auger Eric
2019-06-26 15:12 ` [PATCH v7 5/6] vfio/type1: Add IOVA range capability support Shameer Kolothum
2019-07-07 15:03 ` Auger Eric
2019-06-26 15:12 ` [PATCH v7 6/6] vfio/type1: remove duplicate retrieval of reserved regions Shameer Kolothum
2019-07-07 15:03 ` Auger Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5FC3163CFD30C246ABAA99954A238FA83F2DDED5@lhreml524-mbs.china.huawei.com \
--to=shameerali.kolothum.thodi@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=john.garry@huawei.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).