From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46A9C48BDF for ; Thu, 10 Jun 2021 15:17:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABA786139A for ; Thu, 10 Jun 2021 15:17:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231621AbhFJPTG (ORCPT ); Thu, 10 Jun 2021 11:19:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57411 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231616AbhFJPTE (ORCPT ); Thu, 10 Jun 2021 11:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623338228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/xSRrIzE81bGjheuhkYoLTnfO0+k1xVrIn8oCBsTpxY=; b=Rn3djReRoY2zijzE3m5LEIOzzZzyCRipW+9a/zWdQZDnzImJicQgNJddm9NX+YDFXvsulf 4FyYGZhB8yIQ1in5q0NidRmntyIvBKVYoVT86GA9SjlOqEtAijg1EqEIhdcJBzXRJSMfBp ddk6ZdUeKePirs3OERjL0B9PDkuOvws= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-ZRC_7h8iNRGkUMK3lZFUMg-1; Thu, 10 Jun 2021 11:17:06 -0400 X-MC-Unique: ZRC_7h8iNRGkUMK3lZFUMg-1 Received: by mail-wr1-f70.google.com with SMTP id q15-20020adfc50f0000b0290111f48b865cso1038197wrf.4 for ; Thu, 10 Jun 2021 08:17:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/xSRrIzE81bGjheuhkYoLTnfO0+k1xVrIn8oCBsTpxY=; b=JhhPEEEFOqVQT5Vlsdm2W3Plif6L4bkM4g9dm3nD2UKx+mFwJmEhzoT2/ZJUGNQjSA UITKhEyGM8L9ZBhLNo0ahtmB5Ky2oLucLvrJSG1IOFnh76mERcUWYeRrLyNz+oqdNCxK b5uC3alxolrznF3Nir2FU/rza1oMJSdIeLp9VqGkz9eBFWjDeOdyM+JCRdR0tpzoVSXw c7VVOQ7EFXGlmSICg+zHwoTzWU+DUUVXLy9rOdp7/z6Im1bdSv3s6hbuV5UXlvsdeBzt yU6k0j63mnMa3z71VueeMYWCRyX+zCq4+UkLxDTmsneo+1LavfZORtsVeUFeLZck7l2u zX1g== X-Gm-Message-State: AOAM5316EK+gCZ6uUgxMyoX69KJ//MSWflQ96soyRW4HEgGNoSc2mWyA 2bvRzBXbM1wQ8BI5hVs/dJ5/QRB3pvxa5nqqXQ63Tad2hNRuIAoplFP9eMuvs8/P/z7QPkZ5qxu Fu+O3hdzBuhE1 X-Received: by 2002:a1c:770f:: with SMTP id t15mr5469023wmi.182.1623338225478; Thu, 10 Jun 2021 08:17:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyniLL7r+DAEaQMlKPgbj1DYzIM+sEF3iD8sNZCqVDC2l+Oig0TrJxUUoQsUdhp7IQe4no2gA== X-Received: by 2002:a1c:770f:: with SMTP id t15mr5468989wmi.182.1623338225284; Thu, 10 Jun 2021 08:17:05 -0700 (PDT) Received: from ?IPv6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.gmail.com with ESMTPSA id 89sm4200534wrq.14.2021.06.10.08.17.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 08:17:04 -0700 (PDT) Subject: Re: [PATCH v5 0/7] Hyper-V nested virt enlightenments for SVM To: Vineeth Pillai , Lan Tianyu , Michael Kelley , Sean Christopherson , Vitaly Kuznetsov , Tom Lendacky , Wanpeng Li , Jim Mattson , Joerg Roedel , Wei Liu , Stephen Hemminger , Haiyang Zhang Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "K. Y. Srinivasan" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org References: From: Paolo Bonzini Message-ID: <5af1ccce-a07d-5a13-107b-fc4c4553dd4d@redhat.com> Date: Thu, 10 Jun 2021 17:17:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 03/06/21 17:14, Vineeth Pillai wrote: > This patch series enables the nested virtualization enlightenments for > SVM. This is very similar to the enlightenments for VMX except for the > fact that there is no enlightened VMCS. For SVM, VMCB is already an > architectural in-memory data structure. > > Note: v5 is just a rebase on hyperv-next(5.13-rc1) and needed a rework > based on the patch series: (KVM: VMX: Clean up Hyper-V PV TLB flush) > https://lore.kernel.org/lkml/20210305183123.3978098-1-seanjc@google.com/ > > The supported enlightenments are: > > Enlightened TLB Flush: If this is enabled, ASID invalidations invalidate > only gva -> hpa entries. To flush entries derived from NPT, hyper-v > provided hypercalls (HvFlushGuestPhysicalAddressSpace or > HvFlushGuestPhysicalAddressList) should be used. > > Enlightened MSR bitmap(TLFS 16.5.3): "When enabled, L0 hypervisor does > not monitor the MSR bitmaps for changes. Instead, the L1 hypervisor must > invalidate the corresponding clean field after making changes to one of > the MSR bitmaps." > > Direct Virtual Flush(TLFS 16.8): The hypervisor exposes hypercalls > (HvFlushVirtualAddressSpace, HvFlushVirtualAddressSpaceEx, > HvFlushVirtualAddressList, and HvFlushVirtualAddressListEx) that allow > operating systems to more efficiently manage the virtual TLB. The L1 > hypervisor can choose to allow its guest to use those hypercalls and > delegate the responsibility to handle them to the L0 hypervisor. This > requires the use of a partition assist page." > > L2 Windows boot time was measured with and without the patch. Time was > measured from power on to the login screen and was averaged over a > consecutive 5 trials: > Without the patch: 42 seconds > With the patch: 29 seconds > -- > > Changes from v4 > - Rebased on top of 5.13-rc1 and reworked based on the changes in the > patch series: (KVM: VMX: Clean up Hyper-V PV TLB flush) > > Changes from v3 > - Included definitions for software/hypervisor reserved fields in SVM > architectural data structures. > - Consolidated Hyper-V specific code into svm_onhyperv.[ch] to reduce > the "ifdefs". This change applies only to SVM, VMX is not touched and > is not in the scope of this patch series. > > Changes from v2: > - Refactored the Remote TLB Flush logic into separate hyperv specific > source files (kvm_onhyperv.[ch]). > - Reverted the VMCB Clean bits macro changes as it is no longer needed. > > Changes from v1: > - Move the remote TLB flush related fields from kvm_vcpu_hv and kvm_hv > to kvm_vcpu_arch and kvm_arch. > - Modify the VMCB clean mask runtime based on whether L1 hypervisor > is running on Hyper-V or not. > - Detect Hyper-V nested enlightenments based on > HYPERV_CPUID_VENDOR_AND_MAX_FUNCTIONS. > - Address other minor review comments. > --- > > Vineeth Pillai (7): > hyperv: Detect Nested virtualization support for SVM > hyperv: SVM enlightened TLB flush support flag > KVM: x86: hyper-v: Move the remote TLB flush logic out of vmx > KVM: SVM: Software reserved fields > KVM: SVM: hyper-v: Remote TLB flush for SVM > KVM: SVM: hyper-v: Enlightened MSR-Bitmap support > KVM: SVM: hyper-v: Direct Virtual Flush support > > arch/x86/include/asm/hyperv-tlfs.h | 9 ++ > arch/x86/include/asm/kvm_host.h | 9 ++ > arch/x86/include/asm/svm.h | 9 +- > arch/x86/include/uapi/asm/svm.h | 3 + > arch/x86/kernel/cpu/mshyperv.c | 10 ++- > arch/x86/kvm/Makefile | 9 ++ > arch/x86/kvm/kvm_onhyperv.c | 93 +++++++++++++++++++++ > arch/x86/kvm/kvm_onhyperv.h | 32 +++++++ > arch/x86/kvm/svm/svm.c | 14 ++++ > arch/x86/kvm/svm/svm.h | 22 ++++- > arch/x86/kvm/svm/svm_onhyperv.c | 41 +++++++++ > arch/x86/kvm/svm/svm_onhyperv.h | 129 +++++++++++++++++++++++++++++ > arch/x86/kvm/vmx/vmx.c | 105 +---------------------- > arch/x86/kvm/vmx/vmx.h | 9 -- > arch/x86/kvm/x86.c | 9 ++ > 15 files changed, 384 insertions(+), 119 deletions(-) > create mode 100644 arch/x86/kvm/kvm_onhyperv.c > create mode 100644 arch/x86/kvm/kvm_onhyperv.h > create mode 100644 arch/x86/kvm/svm/svm_onhyperv.c > create mode 100644 arch/x86/kvm/svm/svm_onhyperv.h > Queued, thanks. Paolo