From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Matthew Rosato <mjrosato@linux.ibm.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <liranl@nvidia.com>,
<oren@nvidia.com>, <tzahio@nvidia.com>, <leonro@nvidia.com>,
<yarong@nvidia.com>, <aviadye@nvidia.com>, <shahafs@nvidia.com>,
<artemp@nvidia.com>, <kwankhede@nvidia.com>, <ACurrid@nvidia.com>,
<gmataev@nvidia.com>, <cjia@nvidia.com>, <yishaih@nvidia.com>
Subject: Re: [PATCH 8/9] vfio/pci: use x86 naming instead of igd
Date: Mon, 8 Feb 2021 14:44:14 +0200 [thread overview]
Message-ID: <5bf0b8f7-38fb-bfdf-d093-d8d9b28b9679@nvidia.com> (raw)
In-Reply-To: <d69a7f3c-f552-cd25-4e15-3e894f4eb15a@ozlabs.ru>
On 2/5/2021 2:42 AM, Alexey Kardashevskiy wrote:
>
>
> On 04/02/2021 23:51, Jason Gunthorpe wrote:
>> On Thu, Feb 04, 2021 at 12:05:22PM +1100, Alexey Kardashevskiy wrote:
>>
>>> It is system firmware (==bios) which puts stuff in the device tree. The
>>> stuff is:
>>> 1. emulated pci devices (custom pci bridges), one per nvlink,
>>> emulated by
>>> the firmware, the driver is "ibmnpu" and it is a part on the nvidia
>>> driver;
>>> these are basically config space proxies to the cpu's side of nvlink.
>>> 2. interconnect information - which of 6 gpus nvlinks connected to
>>> which
>>> nvlink on the cpu side, and memory ranges.
>>
>> So what is this vfio_nvlink driver supposed to be bound to?
>>
>> The "emulated pci devices"?
>
> Yes.
>
>> A real GPU function?
>
> Yes.
>
>> A real nvswitch function?
>
> What do you mean by this exactly? The cpu side of nvlink is "emulated
> pci devices", the gpu side is not in pci space at all, the nvidia
> driver manages it via the gpu's mmio or/and cfg space.
>
>> Something else?
>
> Nope :)
> In this new scheme which you are proposing it should be 2 drivers, I
> guess.
I see.
So should it be nvidia_vfio_pci.ko ? and it will do the NVLINK stuff in
case the class code matches and otherwise just work as simple vfio_pci GPU ?
What about the second driver ? should it be called ibmnpu_vfio_pci.ko ?
>
>>
>> Jason
>>
>
next prev parent reply other threads:[~2021-02-08 12:46 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 16:28 [PATCH v2 0/9] Introduce vfio-pci-core subsystem Max Gurtovoy
2021-02-01 16:28 ` [PATCH 1/9] vfio-pci: rename vfio_pci.c to vfio_pci_core.c Max Gurtovoy
2021-02-01 16:28 ` [PATCH 2/9] vfio-pci: introduce vfio_pci_core subsystem driver Max Gurtovoy
2021-02-01 16:28 ` [PATCH 3/9] vfio-pci-core: export vfio_pci_register_dev_region function Max Gurtovoy
2021-02-01 16:28 ` [PATCH 4/9] mlx5-vfio-pci: add new vfio_pci driver for mlx5 devices Max Gurtovoy
2021-02-01 16:28 ` [PATCH 5/9] vfio-pci/zdev: remove unused vdev argument Max Gurtovoy
2021-02-01 17:27 ` Matthew Rosato
2021-02-02 7:57 ` Cornelia Huck
2021-02-02 17:21 ` Alex Williamson
2021-02-01 16:28 ` [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue Max Gurtovoy
2021-02-01 16:52 ` Cornelia Huck
2021-02-01 17:08 ` Matthew Rosato
2021-02-01 20:47 ` Alex Williamson
2021-02-02 7:58 ` Cornelia Huck
2021-02-01 16:28 ` [PATCH 7/9] vfio/pci: use s390 naming instead of zdev Max Gurtovoy
2021-02-01 16:28 ` [PATCH 8/9] vfio/pci: use x86 naming instead of igd Max Gurtovoy
2021-02-01 17:14 ` Cornelia Huck
2021-02-01 17:49 ` Matthew Rosato
2021-02-01 18:42 ` Alex Williamson
2021-02-02 16:06 ` Cornelia Huck
2021-02-02 17:10 ` Jason Gunthorpe
2021-02-11 15:47 ` Max Gurtovoy
2021-02-11 16:29 ` Matthew Rosato
2021-02-11 17:39 ` Cornelia Huck
2021-02-02 17:41 ` Max Gurtovoy
2021-02-02 17:54 ` Alex Williamson
2021-02-02 18:50 ` Jason Gunthorpe
2021-02-02 18:55 ` Christoph Hellwig
2021-02-02 19:05 ` Jason Gunthorpe
2021-02-02 19:37 ` Alex Williamson
2021-02-02 20:44 ` Jason Gunthorpe
2021-02-02 20:59 ` Max Gurtovoy
2021-02-02 21:30 ` Alex Williamson
2021-02-02 23:06 ` Jason Gunthorpe
2021-02-02 23:59 ` Alex Williamson
2021-02-03 13:54 ` Jason Gunthorpe
2021-02-11 8:47 ` Christoph Hellwig
2021-02-11 14:30 ` Jason Gunthorpe
2021-02-11 8:44 ` Christoph Hellwig
2021-02-11 19:43 ` Alex Williamson
[not found] ` <806c138e-685c-0955-7c15-93cb1d4fe0d9@ozlabs.ru>
2021-02-03 16:07 ` Max Gurtovoy
[not found] ` <83ef0164-6291-c3d1-0ce5-2c9d6c97469e@ozlabs.ru>
2021-02-04 12:51 ` Jason Gunthorpe
2021-02-05 0:42 ` Alexey Kardashevskiy
2021-02-08 12:44 ` Max Gurtovoy [this message]
2021-02-09 1:55 ` Alexey Kardashevskiy
2021-02-08 18:13 ` Jason Gunthorpe
2021-02-09 1:51 ` Alexey Kardashevskiy
2021-02-04 9:12 ` Max Gurtovoy
2021-02-11 8:50 ` Christoph Hellwig
2021-02-11 14:49 ` Jason Gunthorpe
2021-02-01 16:28 ` [PATCH 9/9] vfio/pci: use powernv naming instead of nvlink2 Max Gurtovoy
2021-02-01 18:35 ` Jason Gunthorpe
2021-02-10 7:52 ` [PATCH v2 0/9] Introduce vfio-pci-core subsystem Tian, Kevin
2021-02-10 13:34 ` Jason Gunthorpe
2021-02-10 16:37 ` Alex Williamson
2021-02-10 17:08 ` Jason Gunthorpe
2021-02-11 8:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bf0b8f7-38fb-bfdf-d093-d8d9b28b9679@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=ACurrid@nvidia.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=artemp@nvidia.com \
--cc=aviadye@nvidia.com \
--cc=cjia@nvidia.com \
--cc=cohuck@redhat.com \
--cc=gmataev@nvidia.com \
--cc=jgg@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liranl@nvidia.com \
--cc=mjrosato@linux.ibm.com \
--cc=oren@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=tzahio@nvidia.com \
--cc=yarong@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).