From: Eric Farman <farman@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
David Hildenbrand <david@redhat.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/2] KVM: s390: Extend the USER_SIGP capability
Date: Thu, 11 Nov 2021 12:50:05 -0500 [thread overview]
Message-ID: <5c061ba86d5f542380d3d99ce54c5d2331a98b8d.camel@linux.ibm.com> (raw)
In-Reply-To: <55653464-8a84-d741-1b7e-eb4a163f121f@linux.ibm.com>
On Thu, 2021-11-11 at 17:16 +0100, Janosch Frank wrote:
> On 11/10/21 21:33, Eric Farman wrote:
...snip...
> > + case KVM_S390_VCPU_SET_SIGP_BUSY: {
> > + int rc;
> > +
> > + if (!vcpu->kvm->arch.user_sigp_busy)
> > + return -EFAULT;
>
> Huh?
> This should be EINVAL, no?
Of course; my mistake.
>
> > +
> > + rc = kvm_s390_vcpu_set_sigp_busy(vcpu);
> > + VCPU_EVENT(vcpu, 3, "SIGP: CPU %x set busy rc %x",
> > vcpu->vcpu_id, rc);
> > +
> > + return rc;
> > + }
> > + case KVM_S390_VCPU_RESET_SIGP_BUSY: {
> > + if (!vcpu->kvm->arch.user_sigp_busy)
> > + return -EFAULT;
>
> Same
>
>
prev parent reply other threads:[~2021-11-11 17:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 20:33 [RFC PATCH v3 0/2] s390x: Improvements to SIGP handling [KVM] Eric Farman
2021-11-10 20:33 ` [RFC PATCH v3 1/2] Capability/IOCTL/Documentation Eric Farman
2021-11-10 20:33 ` [RFC PATCH v3 2/2] KVM: s390: Extend the USER_SIGP capability Eric Farman
2021-11-11 9:15 ` David Hildenbrand
2021-11-11 15:03 ` Eric Farman
2021-11-11 16:13 ` Janosch Frank
2021-11-11 17:48 ` Eric Farman
2021-11-11 18:29 ` David Hildenbrand
2021-11-11 19:05 ` Eric Farman
2021-11-11 19:15 ` David Hildenbrand
2021-11-11 19:44 ` Eric Farman
2021-11-12 9:34 ` David Hildenbrand
2021-11-12 9:35 ` David Hildenbrand
2021-11-17 7:54 ` Christian Borntraeger
2021-11-19 20:20 ` Eric Farman
2021-11-22 10:52 ` David Hildenbrand
2021-11-23 17:42 ` Eric Farman
2021-11-23 18:44 ` David Hildenbrand
2021-11-30 20:11 ` Eric Farman
2021-11-12 8:49 ` Janosch Frank
2021-11-12 16:09 ` Eric Farman
2021-11-12 20:30 ` Eric Farman
2021-11-11 16:16 ` Janosch Frank
2021-11-11 17:50 ` Eric Farman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c061ba86d5f542380d3d99ce54c5d2331a98b8d.camel@linux.ibm.com \
--to=farman@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).