From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
kvm@vger.kernel.org
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Jim Mattson <jmattson@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: X86: Call kvm_x86_ops.cpuid_update() after CPUIDs fully updated
Date: Thu, 28 May 2020 18:15:29 +0200 [thread overview]
Message-ID: <5d8bc1da-f866-4741-7746-1fa2a3cfbafd@redhat.com> (raw)
In-Reply-To: <1f45de43-af43-24da-b7d3-00b9d2bd517c@intel.com>
On 28/05/20 17:40, Xiaoyao Li wrote:
>>
>>> kvm_x86_ops.cpuid_update() is used to update vmx/svm settings based on
>>> updated CPUID settings. So it's supposed to be called after CPUIDs are
>>> fully updated, not in the middle stage.
>>>
>>> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
>>
>> Are you seeing anything bad happening from this?
>
> Not yet.
>
> IMO changing the order is more reasonable and less confusing.
Indeed, I just could not decide whether to include it in 5.7 or not.
Paolo
next prev parent reply other threads:[~2020-05-28 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:19 [PATCH] KVM: X86: Call kvm_x86_ops.cpuid_update() after CPUIDs fully updated Xiaoyao Li
2020-05-28 15:22 ` Paolo Bonzini
2020-05-28 15:40 ` Xiaoyao Li
2020-05-28 16:15 ` Paolo Bonzini [this message]
2020-05-28 16:59 ` Xiaoyao Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d8bc1da-f866-4741-7746-1fa2a3cfbafd@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).