From: Stephen Donnelly <sfdonnelly@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: Cam Macdonell <cam@cs.ualberta.ca>,
"kvm@vger.kernel.org list" <kvm@vger.kernel.org>
Subject: Re: R/W HG memory mappings with kvm?
Date: Tue, 1 Sep 2009 09:13:03 +1200 [thread overview]
Message-ID: <5f370d430908311413m6cb5951agf8f24e00b75b1eb1@mail.gmail.com> (raw)
In-Reply-To: <4A9B8D5D.2070209@redhat.com>
On Mon, Aug 31, 2009 at 8:44 PM, Avi Kivity<avi@redhat.com> wrote:
> On 08/31/2009 01:33 AM, Stephen Donnelly wrote:
>>
>>> We can't duplicate mm/ in kvm. However, mm/memory.c says:
>>>
>>> * The way we recognize COWed pages within VM_PFNMAP mappings is through
>>> the
>>> * rules set up by "remap_pfn_range()": the vma will have the VM_PFNMAP
>>> bit
>>> * set, and the vm_pgoff will point to the first PFN mapped: thus every
>>> special
>>> * mapping will always honor the rule
>>> *
>>> * pfn_of_page == vma->vm_pgoff + ((addr - vma->vm_start)>>
>>> PAGE_SHIFT)
>>> *
>>> * And for normal mappings this is false.
>>>
>>> So it seems the kvm calculation is right and you should set vm_pgoff in
>>> your
>>> driver.
>>>
>>
>> That may be true for COW pages, which are main memory, but I don't
>> think it is true for device drivers.
>>
>
> No, COW pages have no linear pfn mapping. It's only true for
> remap_pfn_range).
>
>> In a device driver the mmap function receives the vma from the OS. The
>> vm_pgoff field contains the offset area in the file. For drivers this
>> is used to determine where to start the map compared to the io base
>> address.
>>
>> If the driver is mapping io memory to user space it calls
>> io_remap_pfn_range with the pfn for the io memory. The remap_pfn_range
>> call sets the VM_IO and VM_PFNMAP bits in vm_flags. It does not alter
>> the vm_pgoff value.
>>
>> A simple example is hpet_mmap() in drivers/char/hpet.c, or
>> mbcs_gscr_mmap() in drivers/char/mbcs.c.
>>
>
> io_remap_pfn_range() is remap_pfn_range(), which has this:
>
> if (addr == vma->vm_start && end == vma->vm_end) {
> vma->vm_pgoff = pfn;
> vma->vm_flags |= VM_PFN_AT_MMAP;
> }
>
> So remap_pfn_range() will alter the pgoff.
Aha! We are looking at different kernels. I should have mentioned I
was looking at 2.6.28. In mm/memory.c remap_pfn_range() this has:
* There's a horrible special case to handle copy-on-write
* behaviour that some programs depend on. We mark the "original"
* un-COW'ed pages by matching them up with "vma->vm_pgoff".
*/
if (is_cow_mapping(vma->vm_flags)) {
if (addr != vma->vm_start || end != vma->vm_end)
return -EINVAL;
vma->vm_pgoff = pfn;
}
The macro is:
static inline int is_cow_mapping(unsigned int flags)
{
return (flags & (VM_SHARED | VM_MAYWRITE)) == VM_MAYWRITE;
}
Because my vma is marked shared, this clause does not operate and
vm_pgoff is not modified (it is still 0).
> I'm totally confused now.
Sorry about that. The issue is the BUG in gfn_to_pgn where the pfn is
not calculated correctly after looking up the vma.
I still don't see how to get the physical address from the vma, since
vm_pgoff is zero, and the vm_ops are not filled. The vma does not seem
to store the physical base address.
Regards,
Stephen.
next prev parent reply other threads:[~2009-08-31 21:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 22:41 R/W HG memory mappings with kvm? Stephen Donnelly
2009-07-06 7:38 ` Avi Kivity
2009-07-07 22:23 ` Stephen Donnelly
2009-07-08 4:36 ` Avi Kivity
2009-07-08 21:33 ` Stephen Donnelly
2009-07-09 8:10 ` Avi Kivity
2009-07-08 21:45 ` Cam Macdonell
2009-07-08 22:01 ` Stephen Donnelly
2009-07-09 6:01 ` Cam Macdonell
2009-07-09 22:38 ` Stephen Donnelly
2009-07-10 17:03 ` Cam Macdonell
2009-07-12 21:28 ` Stephen Donnelly
2009-07-14 22:25 ` [PATCH] Support shared memory device PCI device Cam Macdonell
[not found] ` <5f370d430907262256rd7f9fdalfbbec1f9492ce86@mail.gmail.com>
2009-07-27 14:48 ` R/W HG memory mappings with kvm? Cam Macdonell
2009-07-27 21:32 ` Stephen Donnelly
2009-07-28 8:54 ` Avi Kivity
2009-07-28 23:06 ` Stephen Donnelly
2009-08-13 4:07 ` Stephen Donnelly
2009-08-19 12:14 ` Avi Kivity
2009-08-23 21:59 ` Stephen Donnelly
2009-08-24 4:55 ` Avi Kivity
2009-08-26 10:22 ` Avi Kivity
2009-08-27 2:39 ` Stephen Donnelly
2009-08-27 2:34 ` Stephen Donnelly
2009-08-27 4:08 ` Avi Kivity
2009-08-30 22:33 ` Stephen Donnelly
2009-08-31 8:44 ` Avi Kivity
2009-08-31 21:13 ` Stephen Donnelly [this message]
2009-09-09 12:50 ` Avi Kivity
2009-07-29 23:52 ` Cam Macdonell
2009-07-30 9:31 ` Avi Kivity
2009-09-28 18:27 Tsuyoshi Ozawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f370d430908311413m6cb5951agf8f24e00b75b1eb1@mail.gmail.com \
--to=sfdonnelly@gmail.com \
--cc=avi@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).