From: Paolo Bonzini <pbonzini@redhat.com>
To: Hamza Mahfooz <someguy@effective-light.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Question regarding the TODO in virt/kvm/kvm_main.c:226
Date: Fri, 25 Jun 2021 19:20:10 +0200 [thread overview]
Message-ID: <5f9d355f-cfd1-d85c-b186-27e7ac573ad9@redhat.com> (raw)
In-Reply-To: <2ZR8VQ.IJMS3PQLNFAS3@effective-light.com>
On 25/06/21 07:16, Hamza Mahfooz wrote:
> ping
>
> On Tue, May 25 2021 at 07:45:53 AM -0400, Hamza Mahfooz
> <someguy@effective-light.com> wrote:
>> Would it be preferable to remove kvm_arch_vcpu_should_kick or
>> kvm_request_needs_ipi when merging them. I ask since, the last time I
>> checked, both functions are only used in kvm_main.c on Linus's tree.
I think none, the logic have changed enough that the TODO is obsolete.
Paolo
prev parent reply other threads:[~2021-06-25 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 11:45 Question regarding the TODO in virt/kvm/kvm_main.c:226 Hamza Mahfooz
2021-06-25 5:16 ` Hamza Mahfooz
2021-06-25 17:20 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9d355f-cfd1-d85c-b186-27e7ac573ad9@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).