From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3463C433DF for ; Thu, 2 Jul 2020 10:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 855E420874 for ; Thu, 2 Jul 2020 10:10:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IxcAsbO6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728351AbgGBKKv (ORCPT ); Thu, 2 Jul 2020 06:10:51 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:37506 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728306AbgGBKKp (ORCPT ); Thu, 2 Jul 2020 06:10:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593684643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tJJoehAPVq0MNpAHqJyOI9O/jCsKkBOYDcH/+KNJTdA=; b=IxcAsbO6nR3HteDmW9SiKWPtFxmNFbkRU+heqPgWTMk8s9Vg0RFYlqEZSLebtR0NWWFJr5 w59h9BI26iusBglnHVQ/CiStjC8LDOvzBSLmIzymf24VqNzsNZQJVOK/SlR//IhYy6kvIx rhD6G3K65jikfRtN6tvmBitwIGsFyK0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-Y_nVFT78NCGRdRnvXNiGGQ-1; Thu, 02 Jul 2020 06:10:41 -0400 X-MC-Unique: Y_nVFT78NCGRdRnvXNiGGQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B048800C60; Thu, 2 Jul 2020 10:10:38 +0000 (UTC) Received: from [10.72.13.163] (ovpn-13-163.pek2.redhat.com [10.72.13.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A90B78120; Thu, 2 Jul 2020 10:10:23 +0000 (UTC) Subject: Re: [RFC PATCH 00/22] Enhance VHOST to enable SoC-to-SoC communication To: Kishon Vijay Abraham I Cc: "Michael S. Tsirkin" , Ohad Ben-Cohen , Bjorn Andersson , Jon Mason , Dave Jiang , Allen Hubbe , Lorenzo Pieralisi , Bjorn Helgaas , Paolo Bonzini , Stefan Hajnoczi , Stefano Garzarella , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-ntb@googlegroups.com, linux-pci@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org References: <20200702082143.25259-1-kishon@ti.com> <20200702055026-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: <603970f5-3289-cd53-82a9-aa62b292c552@redhat.com> Date: Thu, 2 Jul 2020 18:10:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200702055026-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020/7/2 下午5:51, Michael S. Tsirkin wrote: > On Thu, Jul 02, 2020 at 01:51:21PM +0530, Kishon Vijay Abraham I wrote: >> This series enhances Linux Vhost support to enable SoC-to-SoC >> communication over MMIO. This series enables rpmsg communication between >> two SoCs using both PCIe RC<->EP and HOST1-NTB-HOST2 >> >> 1) Modify vhost to use standard Linux driver model >> 2) Add support in vring to access virtqueue over MMIO >> 3) Add vhost client driver for rpmsg >> 4) Add PCIe RC driver (uses virtio) and PCIe EP driver (uses vhost) for >> rpmsg communication between two SoCs connected to each other >> 5) Add NTB Virtio driver and NTB Vhost driver for rpmsg communication >> between two SoCs connected via NTB >> 6) Add configfs to configure the components >> >> UseCase1 : >> >> VHOST RPMSG VIRTIO RPMSG >> + + >> | | >> | | >> | | >> | | >> +-----v------+ +------v-------+ >> | Linux | | Linux | >> | Endpoint | | Root Complex | >> | <-----------------> | >> | | | | >> | SOC1 | | SOC2 | >> +------------+ +--------------+ >> >> UseCase 2: >> >> VHOST RPMSG VIRTIO RPMSG >> + + >> | | >> | | >> | | >> | | >> +------v------+ +------v------+ >> | | | | >> | HOST1 | | HOST2 | >> | | | | >> +------^------+ +------^------+ >> | | >> | | >> +---------------------------------------------------------------------+ >> | +------v------+ +------v------+ | >> | | | | | | >> | | EP | | EP | | >> | | CONTROLLER1 | | CONTROLLER2 | | >> | | <-----------------------------------> | | >> | | | | | | >> | | | | | | >> | | | SoC With Multiple EP Instances | | | >> | | | (Configured using NTB Function) | | | >> | +-------------+ +-------------+ | >> +---------------------------------------------------------------------+ >> >> Software Layering: >> >> The high-level SW layering should look something like below. This series >> adds support only for RPMSG VHOST, however something similar should be >> done for net and scsi. With that any vhost device (PCI, NTB, Platform >> device, user) can use any of the vhost client driver. >> >> >> +----------------+ +-----------+ +------------+ +----------+ >> | RPMSG VHOST | | NET VHOST | | SCSI VHOST | | X | >> +-------^--------+ +-----^-----+ +-----^------+ +----^-----+ >> | | | | >> | | | | >> | | | | >> +-----------v-----------------v--------------v--------------v----------+ >> | VHOST CORE | >> +--------^---------------^--------------------^------------------^-----+ >> | | | | >> | | | | >> | | | | >> +--------v-------+ +----v------+ +----------v----------+ +----v-----+ >> | PCI EPF VHOST | | NTB VHOST | |PLATFORM DEVICE VHOST| | X | >> +----------------+ +-----------+ +---------------------+ +----------+ >> >> This was initially proposed here [1] >> >> [1] -> https://lore.kernel.org/r/2cf00ec4-1ed6-f66e-6897-006d1a5b6390@ti.com > > I find this very interesting. A huge patchset so will take a bit > to review, but I certainly plan to do that. Thanks! Yes, it would be better if there's a git branch for us to have a look. Btw, I'm not sure I get the big picture, but I vaguely feel some of the work is duplicated with vDPA (e.g the epf transport or vhost bus). Have you considered to implement these through vDPA? Thanks > >> Kishon Vijay Abraham I (22): >> vhost: Make _feature_ bits a property of vhost device >> vhost: Introduce standard Linux driver model in VHOST >> vhost: Add ops for the VHOST driver to configure VHOST device >> vringh: Add helpers to access vring in MMIO >> vhost: Add MMIO helpers for operations on vhost virtqueue >> vhost: Introduce configfs entry for configuring VHOST >> virtio_pci: Use request_threaded_irq() instead of request_irq() >> rpmsg: virtio_rpmsg_bus: Disable receive virtqueue callback when >> reading messages >> rpmsg: Introduce configfs entry for configuring rpmsg >> rpmsg: virtio_rpmsg_bus: Add Address Service Notification support >> rpmsg: virtio_rpmsg_bus: Move generic rpmsg structure to >> rpmsg_internal.h >> virtio: Add ops to allocate and free buffer >> rpmsg: virtio_rpmsg_bus: Use virtio_alloc_buffer() and >> virtio_free_buffer() >> rpmsg: Add VHOST based remote processor messaging bus >> samples/rpmsg: Setup delayed work to send message >> samples/rpmsg: Wait for address to be bound to rpdev for sending >> message >> rpmsg.txt: Add Documentation to configure rpmsg using configfs >> virtio_pci: Add VIRTIO driver for VHOST on Configurable PCIe Endpoint >> device >> PCI: endpoint: Add EP function driver to provide VHOST interface >> NTB: Add a new NTB client driver to implement VIRTIO functionality >> NTB: Add a new NTB client driver to implement VHOST functionality >> NTB: Describe the ntb_virtio and ntb_vhost client in the documentation >> >> Documentation/driver-api/ntb.rst | 11 + >> Documentation/rpmsg.txt | 56 + >> drivers/ntb/Kconfig | 18 + >> drivers/ntb/Makefile | 2 + >> drivers/ntb/ntb_vhost.c | 776 +++++++++++ >> drivers/ntb/ntb_virtio.c | 853 ++++++++++++ >> drivers/ntb/ntb_virtio.h | 56 + >> drivers/pci/endpoint/functions/Kconfig | 11 + >> drivers/pci/endpoint/functions/Makefile | 1 + >> .../pci/endpoint/functions/pci-epf-vhost.c | 1144 ++++++++++++++++ >> drivers/rpmsg/Kconfig | 10 + >> drivers/rpmsg/Makefile | 3 +- >> drivers/rpmsg/rpmsg_cfs.c | 394 ++++++ >> drivers/rpmsg/rpmsg_core.c | 7 + >> drivers/rpmsg/rpmsg_internal.h | 136 ++ >> drivers/rpmsg/vhost_rpmsg_bus.c | 1151 +++++++++++++++++ >> drivers/rpmsg/virtio_rpmsg_bus.c | 184 ++- >> drivers/vhost/Kconfig | 1 + >> drivers/vhost/Makefile | 2 +- >> drivers/vhost/net.c | 10 +- >> drivers/vhost/scsi.c | 24 +- >> drivers/vhost/test.c | 17 +- >> drivers/vhost/vdpa.c | 2 +- >> drivers/vhost/vhost.c | 730 ++++++++++- >> drivers/vhost/vhost_cfs.c | 341 +++++ >> drivers/vhost/vringh.c | 332 +++++ >> drivers/vhost/vsock.c | 20 +- >> drivers/virtio/Kconfig | 9 + >> drivers/virtio/Makefile | 1 + >> drivers/virtio/virtio_pci_common.c | 25 +- >> drivers/virtio/virtio_pci_epf.c | 670 ++++++++++ >> include/linux/mod_devicetable.h | 6 + >> include/linux/rpmsg.h | 6 + >> {drivers/vhost => include/linux}/vhost.h | 132 +- >> include/linux/virtio.h | 3 + >> include/linux/virtio_config.h | 42 + >> include/linux/vringh.h | 46 + >> samples/rpmsg/rpmsg_client_sample.c | 32 +- >> tools/virtio/virtio_test.c | 2 +- >> 39 files changed, 7083 insertions(+), 183 deletions(-) >> create mode 100644 drivers/ntb/ntb_vhost.c >> create mode 100644 drivers/ntb/ntb_virtio.c >> create mode 100644 drivers/ntb/ntb_virtio.h >> create mode 100644 drivers/pci/endpoint/functions/pci-epf-vhost.c >> create mode 100644 drivers/rpmsg/rpmsg_cfs.c >> create mode 100644 drivers/rpmsg/vhost_rpmsg_bus.c >> create mode 100644 drivers/vhost/vhost_cfs.c >> create mode 100644 drivers/virtio/virtio_pci_epf.c >> rename {drivers/vhost => include/linux}/vhost.h (66%) >> >> -- >> 2.17.1 >>