From: Thomas Huth <thuth@redhat.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: david@redhat.com, cohuck@redhat.com, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 2/3] configure: s390x: Check if the host key document exists
Date: Mon, 7 Jun 2021 11:48:28 +0200 [thread overview]
Message-ID: <6273f4da-9ce8-965a-dd57-bed917513674@redhat.com> (raw)
In-Reply-To: <20210318125015.45502-3-frankja@linux.ibm.com>
On 18/03/2021 13.50, Janosch Frank wrote:
> I'd rather have a readable error message than make failing the build
> with cryptic errors.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> configure | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index cdcd34e9..4d4bb646 100755
> --- a/configure
> +++ b/configure
> @@ -121,6 +121,11 @@ while [[ "$1" = -* ]]; do
> esac
> done
>
> +if [ "$host_key_document" ] && [ ! -f "$host_key_document" ]; then
Use [ -n "$host_key_document" ] instead of just
[ "$host_key_document" ] ?
With that fixed:
Reviewed-by: Thomas Huth <thuth@redhat.com>
> + echo "Host key document doesn't exist at the specified location."
> + exit 1
> +fi
> +
> if [ "$erratatxt" ] && [ ! -f "$erratatxt" ]; then
> echo "erratatxt: $erratatxt does not exist or is not a regular file"
> exit 1
>
next prev parent reply other threads:[~2021-06-07 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:50 [kvm-unit-tests PATCH 0/3] scripts: Fix PV run handling Janosch Frank
2021-03-18 12:50 ` [kvm-unit-tests PATCH 1/3] s390x: Don't run PV testcases under tcg Janosch Frank
2021-06-07 9:46 ` Thomas Huth
2021-06-07 9:55 ` David Hildenbrand
2021-03-18 12:50 ` [kvm-unit-tests PATCH 2/3] configure: s390x: Check if the host key document exists Janosch Frank
2021-06-07 9:48 ` Thomas Huth [this message]
2021-06-07 9:56 ` David Hildenbrand
2021-03-18 12:50 ` [kvm-unit-tests PATCH 3/3] s390x: run: Skip PV tests when tcg is the accelerator Janosch Frank
2021-06-07 9:54 ` Thomas Huth
2021-06-07 9:57 ` David Hildenbrand
2021-06-07 10:02 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6273f4da-9ce8-965a-dd57-bed917513674@redhat.com \
--to=thuth@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).