From: Pierre Morel <pmorel@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Cornelia Huck <cohuck@redhat.com>
Cc: linux-kernel@vger.kernel.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com,
jasowang@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org,
thomas.lendacky@amd.com, david@gibson.dropbear.id.au,
linuxram@us.ibm.com, heiko.carstens@de.ibm.com,
gor@linux.ibm.com
Subject: Re: [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Date: Tue, 7 Jul 2020 13:19:31 +0200 [thread overview]
Message-ID: <64057bea-2239-1374-b371-abd7256a32bf@linux.ibm.com> (raw)
In-Reply-To: <20200707060838-mutt-send-email-mst@kernel.org>
On 2020-07-07 13:14, Michael S. Tsirkin wrote:
> On Tue, Jul 07, 2020 at 11:46:33AM +0200, Cornelia Huck wrote:
>> On Tue, 7 Jul 2020 10:44:37 +0200
>> Pierre Morel <pmorel@linux.ibm.com> wrote:
>>
>>> S390, protecting the guest memory against unauthorized host access
>>> needs to enforce VIRTIO I/O device protection through the use of
>>> VIRTIO_F_VERSION_1 and VIRTIO_F_IOMMU_PLATFORM.
>>
>> Hm... what about:
>>
>> "If protected virtualization is active on s390, the virtio queues are
>> not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been
>> negotiated. Use the new arch_validate_virtio_features() interface to
>> enforce this."
>
> s/enforce this/fail probe if that's not the case, preventing a host error on access attempt/
>
yes, more complete, thanks.
regards,
Pierre
--
Pierre Morel
IBM Lab Boeblingen
next prev parent reply other threads:[~2020-07-07 11:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 8:44 [PATCH v4 0/2] s390: virtio: let arch validate VIRTIO features Pierre Morel
2020-07-07 8:44 ` [PATCH v4 1/2] " Pierre Morel
2020-07-07 9:26 ` Cornelia Huck
2020-07-07 10:39 ` Pierre Morel
2020-07-07 11:09 ` Christian Borntraeger
2020-07-07 11:17 ` Pierre Morel
2020-07-07 8:44 ` [PATCH v4 2/2] s390: virtio: PV needs VIRTIO I/O device protection Pierre Morel
2020-07-07 9:46 ` Cornelia Huck
2020-07-07 10:38 ` Pierre Morel
2020-07-07 11:19 ` Halil Pasic
2020-07-07 11:14 ` Michael S. Tsirkin
2020-07-07 11:19 ` Pierre Morel [this message]
2020-07-07 11:12 ` Christian Borntraeger
2020-07-07 11:16 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64057bea-2239-1374-b371-abd7256a32bf@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).