From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, "mst@redhat.com" <mst@redhat.com>
Cc: <virtualization@lists.linux-foundation.org>,
<kvm@vger.kernel.org>, <oren@nvidia.com>,
<linux-block@vger.kernel.org>, <axboe@kernel.dk>
Subject: Re: [PATCH 1/1] virtio-blk: remove unneeded "likely" statements
Date: Thu, 2 Sep 2021 22:13:04 +0300 [thread overview]
Message-ID: <6800aad7-038a-b251-4ad5-3dc005b0a8a1@nvidia.com> (raw)
In-Reply-To: <YTDnD1c8rk3SWcx9@stefanha-x1.localdomain>
On 9/2/2021 6:00 PM, Stefan Hajnoczi wrote:
> On Mon, Aug 30, 2021 at 03:01:11PM +0300, Max Gurtovoy wrote:
>> Usually we use "likely/unlikely" to optimize the fast path. Remove
>> redundant "likely" statements in the control path to ease on the code.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>> drivers/block/virtio_blk.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> It would be nice to tweak the commit description before merging this. I
> had trouble parsing the second sentence. If I understand correctly the
> purpose of this patch is to make the code simpler and easier to read:
>
> s/ease on the code/simplify the code and make it easier to read/
I'm ok with this change in commit message.
MST,
can you apply this change if you'll pick this commit ?
-Max.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2021-09-02 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 12:01 [PATCH 1/1] virtio-blk: remove unneeded "likely" statements Max Gurtovoy
2021-09-02 15:00 ` Stefan Hajnoczi
2021-09-02 19:13 ` Max Gurtovoy [this message]
2021-09-03 9:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6800aad7-038a-b251-4ad5-3dc005b0a8a1@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=axboe@kernel.dk \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).