From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6EBC433FE for ; Wed, 5 Oct 2022 06:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbiJEG1j (ORCPT ); Wed, 5 Oct 2022 02:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbiJEG1f (ORCPT ); Wed, 5 Oct 2022 02:27:35 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB3674BB2 for ; Tue, 4 Oct 2022 23:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664951253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hzgr+GJhjprVie4kFrMDBNKKq7b6UhoiqIdbK544F4E=; b=V2pcW8pfnK2k0nFcECm0LecMnB3vZkMTRUXdSdYRuetceQK/ToYQUWbSUi/qr0Aiqokysm 4bg0TZmEtmnJ7uVAwpaifjqX95qQj9ZSBoQdW1Uwp/gGFkNdZbNZSHt9V5kK/K5xcgN60R qWjjvI+oSWSYja8l3tnVtOxzJeLnVZc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-5-BMeEm2_uP-GwbgDJcoTmzA-1; Wed, 05 Oct 2022 02:27:31 -0400 X-MC-Unique: BMeEm2_uP-GwbgDJcoTmzA-1 Received: by mail-wm1-f71.google.com with SMTP id h187-20020a1c21c4000000b003b51369ff1bso536028wmh.3 for ; Tue, 04 Oct 2022 23:27:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=Hzgr+GJhjprVie4kFrMDBNKKq7b6UhoiqIdbK544F4E=; b=vamUYEtdPgu6R/xTvZyigXOvsdoFwCdU4KP04pm/tlCl+2FaJnu9KCMEulny8wJZ/4 PyarKERGDxeAY/qeOmSaIbwKf1DBsGYCZKBVAuNa702WCGbXz8QyxTPwqjv/OMxiHWkk jZAaJAVlkv0krlT/1rCpD7XIY6LJGp4uUoJz2HiTMj+JxI1YnHXJq4BsWWsQ3jvo95J/ Yc4d6ulEj5CVx1isE5g3unHKzxzAgMhrykpC7C2D07hj2xUz/bNqQhwRR+d3y2l49jWV XtDINDGQEfAFsGDir4ItD5YU5Vnw3ffwMCxJb8qVBn5z8rDt9oJw8eVuaK/aTFFv/RLW ozmw== X-Gm-Message-State: ACrzQf1volpB/FPyXM1wE8a7hxNr15nWrHuyCV4C/qyqIF5E9GZd9hxd eH9b6RfvYs8vS458lg3g0v5UohJ8CxAPoMayqk3mNZY0YCb/nKu9+QqQmQ16Z7mqY3NO+wRIchm rSxgHZYXwvq3W X-Received: by 2002:a5d:6dac:0:b0:22a:fbff:b2d3 with SMTP id u12-20020a5d6dac000000b0022afbffb2d3mr17477367wrs.543.1664951250883; Tue, 04 Oct 2022 23:27:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM51k5PL/MMj9nNisaw28ILfu80lWeQorWwHNn3p0/GD+K8Uowfp7d1JM62SxQHy7Gip404Y4Q== X-Received: by 2002:a5d:6dac:0:b0:22a:fbff:b2d3 with SMTP id u12-20020a5d6dac000000b0022afbffb2d3mr17477361wrs.543.1664951250690; Tue, 04 Oct 2022 23:27:30 -0700 (PDT) Received: from [192.168.0.5] (ip-109-43-177-249.web.vodafone.de. [109.43.177.249]) by smtp.gmail.com with ESMTPSA id r6-20020a5d4986000000b0022ccae2fa62sm2068711wrq.22.2022.10.04.23.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Oct 2022 23:27:29 -0700 (PDT) Message-ID: <69854d56-510c-dab0-7cd6-f593ae2bef14@redhat.com> Date: Wed, 5 Oct 2022 08:27:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Janis Schoetterl-Glausch , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev Cc: David Hildenbrand , Jonathan Corbet , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sven Schnelle References: <20220930210751.225873-1-scgl@linux.ibm.com> <20220930210751.225873-4-scgl@linux.ibm.com> <85399389-9b5a-d72a-5db1-b8418008ad58@redhat.com> From: Thomas Huth Subject: Re: [PATCH v1 3/9] Documentation: KVM: s390: Describe KVM_S390_MEMOP_F_CMPXCHG In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 04/10/2022 20.51, Janis Schoetterl-Glausch wrote: > On Tue, 2022-10-04 at 10:16 +0200, Thomas Huth wrote: >> On 30/09/2022 23.07, Janis Schoetterl-Glausch wrote: >>> Describe the semantics of the new KVM_S390_MEMOP_F_CMPXCHG flag for >>> absolute vm write memops which allows user space to perform (storage key >>> checked) cmpxchg operations on guest memory. >>> >>> Signed-off-by: Janis Schoetterl-Glausch >>> --- >>> Documentation/virt/kvm/api.rst | 18 +++++++++++++++++- >>> 1 file changed, 17 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst >>> index abd7c32126ce..0e02d66e38ae 100644 >>> --- a/Documentation/virt/kvm/api.rst >>> +++ b/Documentation/virt/kvm/api.rst >>> @@ -3771,6 +3771,7 @@ Parameters are specified via the following structure:: >>> struct { > > What is the reason you initially didn't copy the /* in */ comment here? You mean in commit 41408c28f283b ? Uh, don't ask me, that's more than 7 years ago... Anyway, please be aware that the MEMOP ioctl is defined as IOW only: #define KVM_S390_MEM_OP _IOW(KVMIO, 0xb1, struct kvm_s390_mem_op) ... so if you now introduce an "out" field in that struct, this might have some impact, e.g. on Valgrind etc. Thomas