From: Marc Zyngier <maz@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: jianyong.wu@arm.com, netdev <netdev@vger.kernel.org>,
Yangbo Lu <yangbo.lu@nxp.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paolo Bonzini <pbonzini@redhat.com>,
seanjc@google.com, Richard Cochran <richardcochran@gmail.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Will Deacon <will@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Andre Przywara <Andre.Przywara@arm.com>,
Steven Price <steven.price@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
kvmarm@lists.cs.columbia.edu, KVM list <kvm@vger.kernel.org>,
Steve Capper <Steve.Capper@arm.com>,
justin.he@arm.com, Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64
Date: Tue, 11 May 2021 10:13:03 +0100 [thread overview]
Message-ID: <6c522f8116f54fa6f23a2d217d966c5a@kernel.org> (raw)
In-Reply-To: <CAMuHMdWd5261ti-zKsroFLvWs0abaWa7G4DKefgPwFb3rEjnNw@mail.gmail.com>
Hi Geert,
On 2021-05-11 10:07, Geert Uytterhoeven wrote:
> Hi Marc, Jianyong,
>
> On Tue, Mar 30, 2021 at 4:56 PM Marc Zyngier <maz@kernel.org> wrote:
>> From: Jianyong Wu <jianyong.wu@arm.com>
>>
>> Currently, there is no mechanism to keep time sync between guest and
>> host
>> in arm/arm64 virtualization environment. Time in guest will drift
>> compared
>> with host after boot up as they may both use third party time sources
>> to correct their time respectively. The time deviation will be in
>> order
>> of milliseconds. But in some scenarios,like in cloud environment, we
>> ask
>> for higher time precision.
>>
>> kvm ptp clock, which chooses the host clock source as a reference
>> clock to sync time between guest and host, has been adopted by x86
>> which takes the time sync order from milliseconds to nanoseconds.
>>
>> This patch enables kvm ptp clock for arm/arm64 and improves clock sync
>> precision
>> significantly.
>
>> --- a/drivers/ptp/Kconfig
>> +++ b/drivers/ptp/Kconfig
>> @@ -108,7 +108,7 @@ config PTP_1588_CLOCK_PCH
>> config PTP_1588_CLOCK_KVM
>> tristate "KVM virtual PTP clock"
>> depends on PTP_1588_CLOCK
>> - depends on KVM_GUEST && X86
>> + depends on (KVM_GUEST && X86) || (HAVE_ARM_SMCCC_DISCOVERY &&
>> ARM_ARCH_TIMER)
>
> Why does this not depend on KVM_GUEST on ARM?
> I.e. shouldn't the dependency be:
>
> KVM_GUEST && (X86 || (HAVE_ARM_SMCCC_DISCOVERY && ARM_ARCH_TIMER))
>
> ?
arm/arm64 do not select KVM_GUEST. Any kernel can be used for a guest,
and KVM/arm64 doesn't know about this configuration symbol.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2021-05-11 9:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:54 [PATCH v19 0/7] KVM: arm64: Add host/guest KVM-PTP support Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 1/7] arm/arm64: Probe for the presence of KVM hypervisor Marc Zyngier
2021-04-17 9:49 ` Zenghui Yu
2021-03-30 14:54 ` [PATCH v19 2/7] KVM: arm64: Advertise KVM UID to guests via SMCCC Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 3/7] ptp: Reorganize ptp_kvm.c to make it arch-independent Marc Zyngier
2021-04-07 9:28 ` Marc Zyngier
2021-04-07 15:13 ` Richard Cochran
2021-04-07 15:31 ` Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 4/7] time: Add mechanism to recognize clocksource in time_get_snapshot Marc Zyngier
2021-04-17 9:27 ` Zenghui Yu
2021-03-30 14:54 ` [PATCH v19 5/7] clocksource: Add clocksource id for arm arch counter Marc Zyngier
2021-03-30 14:54 ` [PATCH v19 6/7] KVM: arm64: Add support for the KVM PTP service Marc Zyngier
2021-04-17 8:59 ` Zenghui Yu
2021-04-17 9:10 ` Marc Zyngier
2021-04-17 10:24 ` Zenghui Yu
2021-03-30 14:54 ` [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64 Marc Zyngier
2021-04-17 8:42 ` Zenghui Yu
2021-04-17 9:05 ` Marc Zyngier
2021-05-11 9:07 ` Geert Uytterhoeven
2021-05-11 9:13 ` Marc Zyngier [this message]
2021-05-26 7:52 ` Geert Uytterhoeven
2021-05-26 8:01 ` Marc Zyngier
2021-05-26 8:18 ` Geert Uytterhoeven
2021-05-26 8:32 ` Marc Zyngier
2021-05-26 8:50 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c522f8116f54fa6f23a2d217d966c5a@kernel.org \
--to=maz@kernel.org \
--cc=Andre.Przywara@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Steve.Capper@arm.com \
--cc=geert@linux-m68k.org \
--cc=jianyong.wu@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kernel-team@android.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=richardcochran@gmail.com \
--cc=seanjc@google.com \
--cc=steven.price@arm.com \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).