kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, xieyongji@bytedance.com,
	stefanha@redhat.com, file@sect.tu-berlin.de,
	ashish.kalra@amd.com, martin.radev@aisec.fraunhofer.de,
	konrad.wilk@oracle.com, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 0/7] Untrusted device support for virtio
Date: Sun, 25 Apr 2021 09:43:17 +0800	[thread overview]
Message-ID: <708f1a31-b4dd-d0b9-cb1e-e94b75a5a752@redhat.com> (raw)
In-Reply-To: <20210423161114-mutt-send-email-mst@kernel.org>


在 2021/4/24 上午4:14, Michael S. Tsirkin 写道:
> On Thu, Apr 22, 2021 at 04:19:16PM +0800, Jason Wang wrote:
>> 在 2021/4/22 下午2:31, Christoph Hellwig 写道:
>>> On Wed, Apr 21, 2021 at 11:21:10AM +0800, Jason Wang wrote:
>>>> The behaivor for non DMA API is kept for minimizing the performance
>>>> impact.
>>> NAK.  Everyone should be using the DMA API in a modern world.  So
>>> treating the DMA API path worse than the broken legacy path does not
>>> make any sense whatsoever.
>>
>> I think the goal is not treat DMA API path worse than legacy. The issue is
>> that the management layer should guarantee that ACCESS_PLATFORM is set so
>> DMA API is guaranteed to be used by the driver. So I'm not sure how much
>> value we can gain from trying to 'fix' the legacy path. But I can change the
>> behavior of legacy path to match DMA API path.
>>
>> Thanks
> I think before we maintain different paths with/without ACCESS_PLATFORM
> it's worth checking whether it's even a net gain. Avoiding sharing
> by storing data in private memory can actually turn out to be
> a net gain even without DMA API.


I agree.


>
> It is worth checking what is the performance effect of this patch.


So I've posted v2, where private memory is used in no DMA API path (as 
what has been done in packed).

Pktgen and netperf doens't see obvious difference.

Thanks


>
>


  reply	other threads:[~2021-04-25  1:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21  3:21 [RFC PATCH 0/7] Untrusted device support for virtio Jason Wang
2021-04-21  3:21 ` [RFC PATCH 1/7] virtio-ring: maintain next in extra state for packed virtqueue Jason Wang
2021-04-21  3:21 ` [RFC PATCH 2/7] virtio_ring: rename vring_desc_extra_packed Jason Wang
2021-04-21  3:21 ` [RFC PATCH 3/7] virtio-ring: factor out desc_extra allocation Jason Wang
2021-04-21  3:21 ` [RFC PATCH 4/7] virtio_ring: secure handling of mapping errors Jason Wang
2021-04-21  3:21 ` [RFC PATCH 5/7] virtio_ring: introduce virtqueue_desc_add_split() Jason Wang
2021-04-21  3:21 ` [RFC PATCH 6/7] virtio: use err label in __vring_new_virtqueue() Jason Wang
2021-04-21  3:21 ` [RFC PATCH 7/7] virtio-ring: store DMA metadata in desc_extra for split virtqueue Jason Wang
2021-04-22  6:31 ` [RFC PATCH 0/7] Untrusted device support for virtio Christoph Hellwig
2021-04-22  8:19   ` Jason Wang
2021-04-23 20:14     ` Michael S. Tsirkin
2021-04-25  1:43       ` Jason Wang [this message]
2021-04-28 21:06 ` Konrad Rzeszutek Wilk
2021-04-29  4:16   ` Jason Wang
2021-06-04 15:17     ` Konrad Rzeszutek Wilk
2021-06-07  2:46       ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=708f1a31-b4dd-d0b9-cb1e-e94b75a5a752@redhat.com \
    --to=jasowang@redhat.com \
    --cc=ashish.kalra@amd.com \
    --cc=file@sect.tu-berlin.de \
    --cc=hch@infradead.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.radev@aisec.fraunhofer.de \
    --cc=mst@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).