From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53C3FC433E1 for ; Wed, 27 May 2020 13:27:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 325B3208C3 for ; Wed, 27 May 2020 13:27:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zwtz3KVN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387730AbgE0N1H (ORCPT ); Wed, 27 May 2020 09:27:07 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37166 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387594AbgE0N1E (ORCPT ); Wed, 27 May 2020 09:27:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590586022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rO0Xmu3kpwaS+spo70btHKk/n/bl2TDfOUNRISjvedY=; b=Zwtz3KVNBkXkOAz7DJgnrvHQF910iCD0DumL8CXrwm+AxuidxSFfM0RhTeC+ggATVChFy3 VFlVuy7lUS8/hAoKFNgHbMJzej25iaW6narm54BNj/1QRjgpaSt4P4s83CDeu0S6YKgIOL Fvydh9KyOOeBFinUXN8p0rU7UmSj9po= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-JCs4iwIVN_e-0IEb527jxA-1; Wed, 27 May 2020 09:26:59 -0400 X-MC-Unique: JCs4iwIVN_e-0IEb527jxA-1 Received: by mail-wr1-f69.google.com with SMTP id a4so2045263wrp.5 for ; Wed, 27 May 2020 06:26:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rO0Xmu3kpwaS+spo70btHKk/n/bl2TDfOUNRISjvedY=; b=UwzEgtFwSrnpOLNeU3KJAI9S4L9GmihyU1bu9Cq7I38RP3iB+lVxsqE6YWByMkzeHh qM2Rc/e4wyLVvbiD2lZ3jVDiH5jKi24Vu+I/35UXZPvQjB9BrYK0HievaV5+60cZOG10 6PQVcfPNYUP+09iIaIowkmWssMDupeA1uuKYWaix5dgc3rCOA44pzdcWUvAf9VT/slbo vpg3QqKVqJBIocHA00OybAPl6cbwxOHsZQGK2WXz91CFNW3u/uQrS/ar0s+aWW0VtYb2 lRKIsRVsyUoMCi6YzDLixi3CVr17iiHttRqyGVujpZzmQHr3w+ZY2pB9jQ3Hje66H3pF pEPw== X-Gm-Message-State: AOAM530lu/kd7/pAnZ1WhyAV5m3TAH979C1j3syHD5/DuUvT8zaAZfNW yOYJDBccvZWTP7zKQSiSZqQMeLjzYHFSxpDk9XGzVk+8GiGH0n8oktLr5QUlNgb22+sy8mADMeU 9T7V3xaT0pwQd X-Received: by 2002:adf:f582:: with SMTP id f2mr23080019wro.204.1590586018590; Wed, 27 May 2020 06:26:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzksEVrGsPk/xGJQnD5AtcYNTpqAooqkuvHIUr1bqlDBm3LvIU1wHX3ffnsooF7m2BY4wdfbQ== X-Received: by 2002:adf:f582:: with SMTP id f2mr23079984wro.204.1590586018345; Wed, 27 May 2020 06:26:58 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.225]) by smtp.gmail.com with ESMTPSA id c25sm2844600wmb.44.2020.05.27.06.26.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 06:26:57 -0700 (PDT) Subject: Re: [PATCH v3 3/7] kunit: tests for stats_fs API To: Alan Maguire Cc: kvm@vger.kernel.org, Christian Borntraeger , Paolo Bonzini , Jim Mattson , Alexander Viro , Emanuele Giuseppe Esposito , David Rientjes , Jonathan Adams , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, brendanhiggins@google.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com References: <20200526110318.69006-1-eesposit@redhat.com> <20200526110318.69006-4-eesposit@redhat.com> From: Emanuele Giuseppe Esposito Message-ID: <7178ea00-cee5-d5e9-a7aa-58aa46ee416a@redhat.com> Date: Wed, 27 May 2020 15:26:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org >> In order to run them, the kernel .config must set CONFIG_KUNIT=y >> and a new .kunitconfig file must be created with CONFIG_STATS_FS=y >> and CONFIG_STATS_FS_TEST=y >> > > It looks like CONFIG_STATS_FS is built-in, but it exports > much of the functionality you are testing. However could the > tests also be built as a module (i.e. make CONFIG_STATS_FS_TEST > a tristate variable)? To test this you'd need to specify > CONFIG_KUNIT=m and CONFIG_STATS_FS_TEST=m, and testing would > simply be a case of "modprobe"ing the stats fs module and collecting > results in /sys/kernel/debug/kunit/ (rather > than running kunit.py). Are you relying on unexported internals in > the the tests that would prevent building them as a module? > I haven't checked it yet, but tests should work as separate module. I will look into it, thanks. Emanuele