From: linmiaohe <linmiaohe@huawei.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"jmattson@google.com" <jmattson@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"liran.alon@oracle.com" <liran.alon@oracle.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF
Date: Tue, 14 Jan 2020 02:15:28 +0000 [thread overview]
Message-ID: <724c22eff5f94a338e0f8af4f2c1df93@huawei.com> (raw)
Hi,
On Mon, Jan 13, 2020 at 12:09:42PM -0800, Sean Christopherson wrote:
> > On Sat, Dec 28, 2019 at 02:25:24PM +0800, linmiaohe wrote:
> > > From: Miaohe Lin <linmiaohe@huawei.com>
> > >
> > > In case writing to vmread destination operand result in a #PF,
> > vmread should not call nested_vmx_succeed() to set rflags to specify success.
> > > Similar to as done in VMPTRST (See handle_vmptrst()).
> > >
> > > Reviewed-by: Liran Alon <liran.alon@oracle.com>
> > > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> >
> > Reviewed-by: Sean Christopherson <sean.j.christopherson@intel.com>
>
> Gah, got trigger happy. This could also have "Cc: stable@vger.kernel.org".
> With that, my Reviewed-by stands :-).
Many thanks for your review. I would add Cc tag and resend a v3. Thanks again.
next reply other threads:[~2020-01-14 2:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 2:15 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-28 6:25 [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF linmiaohe
2020-01-13 20:09 ` Sean Christopherson
2020-01-13 20:11 ` Sean Christopherson
2020-01-15 18:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724c22eff5f94a338e0f8af4f2c1df93@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).