KVM Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH] vfio/pci: Avoid a null pointer dereference in vfio_config_free()
@ 2020-05-22  9:42 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-22  9:42 UTC (permalink / raw)
  To: Qian Cai, kvm
  Cc: kernel-janitors, linux-kernel, Alex Williamson, Cornelia Huck

> It is possible vfio_config_init() does not call vfio_cap_len(), and then
> vdev->msi_perm == NULL. Later, in vfio_config_free(), it could trigger a
> null-ptr-deref.

I suggest to add an imperative wording to the commit message.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=051143e1602d90ea71887d92363edd539d411de5#n151

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22  9:42 [PATCH] vfio/pci: Avoid a null pointer dereference in vfio_config_free() Markus Elfring

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git