From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FC42C4332F for ; Thu, 21 Oct 2021 15:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26CA860C49 for ; Thu, 21 Oct 2021 15:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231485AbhJUPZK (ORCPT ); Thu, 21 Oct 2021 11:25:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21264 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230280AbhJUPZI (ORCPT ); Thu, 21 Oct 2021 11:25:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634829771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pB0OKk0sXihZTGW0ponhLiCPuMdm6BJGDBBh4jppD/I=; b=MWs6+Z1lBUU9D7EqZqt2r3z4J+8HqRTe91zSkMHMcFOcY3Ne2JuLbQccHaS/Z+arXbJNrz HOVbtZxCXVXMTr2Nvb/7suDYec/eZVvoC2Yf4FuLGDqv3bpv6kpkyrTAuqins4sI+m+CuB 5fuXq6145tW2ga3UNI3nY8HD/040efo= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-Alkw2o0vP_OM7-Xzmq6iNw-1; Thu, 21 Oct 2021 11:22:50 -0400 X-MC-Unique: Alkw2o0vP_OM7-Xzmq6iNw-1 Received: by mail-ed1-f70.google.com with SMTP id e14-20020a056402088e00b003db6ebb9526so660246edy.22 for ; Thu, 21 Oct 2021 08:22:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pB0OKk0sXihZTGW0ponhLiCPuMdm6BJGDBBh4jppD/I=; b=0NLSooH1H5ai2FGsmF2FdppObpLhi+M6ReynqSEER7Cfakl8+/kRC505RXDRYzu1kz UWXy2pqpyVtcsjdrVFv9N7h5rTLftBshnuxnwRHPyY4uW2LowV5GVv2/51f5oG31cbH/ xjFVac6mhkzRsFNZkn3zbdskmF27+Z6eSdGL/FOd/TMyL1y2xUwMuKBaRen7nj4LWM3m wA6Y8NSVjj9T1bd0SlH94wKbn9NY/Lus6pgzvn/tAGY5yui/VOId1Z36oJwyogOuRKtj kM7RSHhCCUiOdUavVcqQV3KCLSOnDARupZD3ZZS15w/0t+P5wi6P6StBFECSl0Vchc/G gsFw== X-Gm-Message-State: AOAM530MmjVM91tJqJarHJBToX/8kDcbAtLfa9iGMgLqonVe7VWiuzRj FkXw2cxEy54R7u4XYhGWQ9Mu8/Rwl5f7JrOCaICPogiiP7LwG8kcZLsAUjCXc7kTOLR/4b7gjn6 RnkyxL9WMYqA4 X-Received: by 2002:a05:6402:22d6:: with SMTP id dm22mr8188890edb.67.1634829769338; Thu, 21 Oct 2021 08:22:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm5zy+bVdhGS6ehh9nY0zcbRzhx5q8oMxMLk/wp+LnBV7GtCAZEJhxnoikSAKgtbD7UE1Gkw== X-Received: by 2002:a05:6402:22d6:: with SMTP id dm22mr8188866edb.67.1634829769164; Thu, 21 Oct 2021 08:22:49 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id c8sm2772289edt.55.2021.10.21.08.22.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Oct 2021 08:22:48 -0700 (PDT) Message-ID: <7920a4e5-edb4-504c-a30b-7410e425eb14@redhat.com> Date: Thu, 21 Oct 2021 17:22:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [RFC 02/16] KVM: selftests: add hooks for managing encrypted guest memory Content-Language: en-US To: Michael Roth , Krish Sadhukhan Cc: linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Nathan Tempelman , Marc Orr , Steve Rutherford , Sean Christopherson , Mingwei Zhang , Brijesh Singh , Tom Lendacky , Varad Gautam , Shuah Khan , Vitaly Kuznetsov , David Woodhouse , Ricardo Koller , Jim Mattson , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" References: <20211005234459.430873-1-michael.roth@amd.com> <20211005234459.430873-3-michael.roth@amd.com> <6b8e4fb7-fb96-bc3a-dc46-70d9f07d3c8d@oracle.com> <20211013150719.mnde2lw6ffks7pm4@amd.com> From: Paolo Bonzini In-Reply-To: <20211013150719.mnde2lw6ffks7pm4@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 13/10/21 17:07, Michael Roth wrote: >> >> For readability, it's probably better to adopt a standard naming convention >> for structures, members and  functions ?  For example, >> >>         encrypted_phy_pages    ->     enc_phy_pages >> >>         struct vm_memcrypt  {    ->    struct vm_mem_enc { >> >>         struct vm_memcrypt memcrypt    ->    struct vm_mem_enc  mem_enc >> >>         vm_get_encrypted_phy_pages()    -> vm_get_enc_phy_pages >> >> >> > Makes sense, I will use this naming convention for the next spin. And again I liked yours more. :) Paolo