From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1357C433B4 for ; Wed, 12 May 2021 06:33:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA118617C9 for ; Wed, 12 May 2021 06:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230017AbhELGe5 (ORCPT ); Wed, 12 May 2021 02:34:57 -0400 Received: from mga03.intel.com ([134.134.136.65]:50318 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbhELGe5 (ORCPT ); Wed, 12 May 2021 02:34:57 -0400 IronPort-SDR: AIvBH+p0FwgO1Db34YUXolYcJqzjgUlL/PmCv3vZVKjqRnbWxqQ4f8JpIJvvUl+mlbSg5aYnPJ a0PBCaQRmG3A== X-IronPort-AV: E=McAfee;i="6200,9189,9981"; a="199680549" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="199680549" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 23:33:48 -0700 IronPort-SDR: sf0ON/yVTei43URmDwlcK7aD6Qo9w14AKOXW9R0yfaAc/z4+YHvHz2iMC89ipSguUim/ein8Ak WOIQYx134Z3Q== X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="437047272" Received: from likexu-mobl1.ccr.corp.intel.com (HELO [10.238.4.93]) ([10.238.4.93]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2021 23:33:46 -0700 Subject: Re: [kvm-unit-tests PATCH] x86: pmu: Test full-width counter writes support To: Jim Mattson Cc: Paolo Bonzini , kvm list , Thomas Huth , Andrew Jones References: <20200529074347.124619-1-like.xu@linux.intel.com> <20200529074347.124619-4-like.xu@linux.intel.com> From: Like Xu Organization: Intel OTC Message-ID: <7c44617d-39f5-4e82-ee45-f0d142ba0dbc@linux.intel.com> Date: Wed, 12 May 2021 14:33:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021/5/12 5:27, Jim Mattson wrote: > On Fri, May 29, 2020 at 12:44 AM Like Xu wrote: >> >> When the full-width writes capability is set, use the alternative MSR >> range to write larger sign counter values (up to GP counter width). >> >> Signed-off-by: Like Xu >> --- > >> + /* >> + * MSR_IA32_PMCn supports writing values ​​up to GP counter width, >> + * and only the lowest bits of GP counter width are valid. >> + */ > > Could you rewrite this comment in ASCII, please? I would do it, but > I'm not sure what the correct translation is. > My first submitted patch says that they are just Unicode "ZERO WIDTH SPACE". https://lore.kernel.org/kvm/20200508083218.120559-2-like.xu@linux.intel.com/ Here you go: --- From 1b058846aabcd7a85b5c5f41cb2b63b6a348bdc4 Mon Sep 17 00:00:00 2001 From: Like Xu Date: Wed, 12 May 2021 14:26:40 +0800 Subject: [PATCH] x86: pmu: Fix a comment about full-width counter writes support Remove two Unicode characters 'ZERO WIDTH SPACE' (U+200B). Fixes: 22f2901a0e ("x86: pmu: Test full-width counter writes support") Reported-by: Jim Mattson Signed-off-by: Like Xu --- x86/pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x86/pmu.c b/x86/pmu.c index 5a3d55b..6cb3506 100644 --- a/x86/pmu.c +++ b/x86/pmu.c @@ -510,7 +510,7 @@ static void check_gp_counters_write_width(void) } /* - * MSR_IA32_PMCn supports writing values ​​up to GP counter width, + * MSR_IA32_PMCn supports writing values up to GP counter width, * and only the lowest bits of GP counter width are valid. */ for (i = 0; i < num_counters; i++) { -- 2.31.1