From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 001DEC32771 for ; Wed, 15 Jan 2020 17:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD1C7214AF for ; Wed, 15 Jan 2020 17:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G1q1FRlA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729030AbgAORQP (ORCPT ); Wed, 15 Jan 2020 12:16:15 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:48064 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729011AbgAORQO (ORCPT ); Wed, 15 Jan 2020 12:16:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579108573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=egZNg4z+3DEsO7Uh92E/wohzRqRs+BEyWekqiG5mUKo=; b=G1q1FRlARb51k+GE+Vev9Nvr/BHsKM84bk6j8VXEM4RxRDYoaTNHYWuccqoIwG4MWfSvOb cscGKlfGDwHODc+ZE2+fnENuPmBkhv4aY8J/QjhZKgn4m6b7auq15WbkxqXKIUAa+nmNBT huVu/473Csb9Q7rLOu+BlNMg8j7wcMk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-EnYCrDZIOQ21-_2h5WbbuQ-1; Wed, 15 Jan 2020 12:16:11 -0500 X-MC-Unique: EnYCrDZIOQ21-_2h5WbbuQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 94A881022902; Wed, 15 Jan 2020 17:16:09 +0000 (UTC) Received: from [10.36.117.108] (ovpn-117-108.ams2.redhat.com [10.36.117.108]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 946751081318; Wed, 15 Jan 2020 17:16:06 +0000 (UTC) Subject: Re: [kvm-unit-tests PATCH v2 06/16] arm/arm64: ITS: Test BASER To: Andrew Jones Cc: eric.auger.pro@gmail.com, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, peter.maydell@linaro.org, yuzenghui@huawei.com, alexandru.elisei@arm.com, thuth@redhat.com References: <20200110145412.14937-1-eric.auger@redhat.com> <20200110145412.14937-7-eric.auger@redhat.com> <20200113172110.27p3bgozit6djf7k@kamzik.brq.redhat.com> From: Auger Eric Message-ID: <823a0516-6c20-b1f3-49ca-3c0379c353f3@redhat.com> Date: Wed, 15 Jan 2020 18:16:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20200113172110.27p3bgozit6djf7k@kamzik.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, On 1/13/20 6:21 PM, Andrew Jones wrote: > On Fri, Jan 10, 2020 at 03:54:02PM +0100, Eric Auger wrote: >> Add helper routines to parse and set up BASER registers. >> Add a new test dedicated to BASER accesses. >> >> Signed-off-by: Eric Auger >> >> --- >> >> v2 -> v3: >> - remove everything related to memory attributes >> - s/dev_baser/coll_baser/ in report_info >> - add extra line >> - removed index filed in its_baser >> --- >> arm/gic.c | 21 ++++++++++- >> arm/unittests.cfg | 6 +++ >> lib/arm/asm/gic-v3-its.h | 14 +++++++ >> lib/arm/gic-v3-its.c | 80 ++++++++++++++++++++++++++++++++++++++++ >> 4 files changed, 120 insertions(+), 1 deletion(-) >> >> diff --git a/arm/gic.c b/arm/gic.c >> index adeb981..3597ac3 100644 >> --- a/arm/gic.c >> +++ b/arm/gic.c >> @@ -531,11 +531,26 @@ static void test_its_introspection(void) >> typer->collid_bits); >> report(typer->eventid_bits && typer->deviceid_bits && >> typer->collid_bits, "ID spaces"); >> - report(!typer->hw_collections, "collections only in ext memory"); >> report_info("Target address format %s", >> typer->pta ? "Redist basse address" : "PE #"); >> } >> >> +static void test_its_baser(void) >> +{ >> + struct its_baser *dev_baser, *coll_baser; >> + >> + if (!gicv3_its_base()) { >> + report_skip("No ITS, skip ..."); >> + return; >> + } >> + >> + dev_baser = its_lookup_baser(GITS_BASER_TYPE_DEVICE); >> + coll_baser = its_lookup_baser(GITS_BASER_TYPE_COLLECTION); >> + report(dev_baser && coll_baser, "detect device and collection BASER"); >> + report_info("device baser entry_size = 0x%x", dev_baser->esz); >> + report_info("collection baser entry_size = 0x%x", coll_baser->esz); >> +} >> + >> int main(int argc, char **argv) >> { >> if (!gic_init()) { >> @@ -571,6 +586,10 @@ int main(int argc, char **argv) >> report_prefix_push(argv[1]); >> test_its_introspection(); >> report_prefix_pop(); >> + } else if (strcmp(argv[1], "its-baser") == 0) { >> + report_prefix_push(argv[1]); >> + test_its_baser(); >> + report_prefix_pop(); >> } else { >> report_abort("Unknown subtest '%s'", argv[1]); >> } >> diff --git a/arm/unittests.cfg b/arm/unittests.cfg >> index bd20460..2234a0f 100644 >> --- a/arm/unittests.cfg >> +++ b/arm/unittests.cfg >> @@ -128,6 +128,12 @@ smp = $MAX_SMP >> extra_params = -machine gic-version=3 -append 'its-introspection' >> groups = its >> >> +[its-baser] >> +file = gic.flat >> +smp = $MAX_SMP >> +extra_params = -machine gic-version=3 -append 'its-baser' >> +groups = its > > Do these tests need to be run separately from the its-introspection tests > for some reason? If not, then I'd combine them. Not really. To me it is easier to debug and analyze when the fail though. I will merge both. Thanks Eric > > Thanks, > drew >